Re: [net-next PATCH v14 06/16] net: mdio: regmap: prepare support for multiple valid addr

Andrew Lunn
2025-04-10T17:13:50Z

On Tue, Apr 08, 2025 at 11:51:13AM +0200, Christian Marangi wrote:
> Rework the valid_addr and convert it to a mask in preparation for mdio
> regmap to support multiple valid addr in the case the regmap can support
> it.
> mr = mii->priv;
> mr->regmap = config->regmap;
> - mr->valid_addr = config->valid_addr;
> + mr->valid_addr_mask = BIT(config->valid_addr);

I don't see how this allows you to support multiple addresses. You
still only have one bit set in mr->valid_addr_mask.

Andrew