From: Marek Pazdan <mpazdan@arista.com>
To: kory.maincent@bootlin.com
Cc: aleksander.lobakin@intel.com, almasrymina@google.com,
andrew+netdev@lunn.ch, anthony.l.nguyen@intel.com,
daniel.zahka@gmail.com, davem@davemloft.net,
ecree.xilinx@gmail.com, edumazet@google.com, gal@nvidia.com,
horms@kernel.org, intel-wired-lan@lists.osuosl.org,
jianbol@nvidia.com, kuba@kernel.org,
linux-kernel@vger.kernel.org, mpazdan@arista.com,
netdev@vger.kernel.org, pabeni@redhat.com,
przemyslaw.kitszel@intel.com, willemb@google.com
Subject: Re: [Intel-wired-lan] [PATCH 1/2] ethtool: transceiver reset and presence pin control
Date: Tue, 8 Apr 2025 15:54:14 +0000 [thread overview]
Message-ID: <20250408155844.30790-1-mpazdan@arista.com> (raw)
In-Reply-To: <20250407153203.0a3037d7@kmaincent-XPS-13-7390>
On Mon, 7 Apr 2025 15:32:03 +0200 Kory Maincent wrote:
> ETHTOOL_PHY_G/STUNABLE IOCTLs are targeting the PHY of the NIC but IIUC in your
> case you are targeting the reset of the QSFP module. Maybe phylink API is more
> appropriate for this feature.
>
> You have to add net-next prefix in the subject like this [PATCH net-next 1/2]
> when you add new support to net subsystem.
Thanks for review.
From up to now replies I see that there are concerns regarding usage phy-tunable ethtool
option for this purpose, so I will post updated patches after we clarify proper way to go.
I need to check more on phylink API, from the overview I read:
"phylink is a mechanism to support hot-pluggable networking modules directly connected
to a MAC without needing to re-initialise the adapter on hot-plug events.
phylink supports conventional phylib-based setups, fixed link setups
and SFP (Small Formfactor Pluggable) modules at present."
I don't see QSFP modules are being supported but I need to verify impact of this.
As I mentioned in other reply this API should allow for transceiver module reset
from user space if orchestration agent detects transceiver failure state or when
it gets direct request from Cli.
next prev parent reply other threads:[~2025-04-08 15:58 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-07 12:35 [PATCH 1/2] ethtool: transceiver reset and presence pin control Marek Pazdan
2025-04-07 12:35 ` [PATCH 2/2] ice: add qsfp " Marek Pazdan
2025-04-07 13:46 ` Kory Maincent
2025-04-07 20:30 ` Andrew Lunn
2025-04-08 14:22 ` [Intel-wired-lan] " Marek Pazdan
2025-04-08 15:23 ` Andrew Lunn
2025-04-07 13:32 ` [PATCH 1/2] ethtool: " Kory Maincent
2025-04-08 15:54 ` Marek Pazdan [this message]
2025-04-07 20:39 ` Andrew Lunn
2025-04-08 15:32 ` [Intel-wired-lan] " Marek Pazdan
2025-04-08 16:10 ` Andrew Lunn
2025-05-13 22:40 ` [PATCH net-next v2 1/2] ethtool: qsfp transceiver reset, interrupt " Marek Pazdan
2025-05-13 22:40 ` [Intel-wired-lan] [PATCH net-next v2 2/2] ice: add " Marek Pazdan
2025-05-15 1:23 ` Andrew Lunn
2025-05-14 0:26 ` [PATCH net-next v2 1/2] ethtool: " Jakub Kicinski
2025-05-15 1:10 ` Andrew Lunn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250408155844.30790-1-mpazdan@arista.com \
--to=mpazdan@arista.com \
--cc=aleksander.lobakin@intel.com \
--cc=almasrymina@google.com \
--cc=andrew+netdev@lunn.ch \
--cc=anthony.l.nguyen@intel.com \
--cc=daniel.zahka@gmail.com \
--cc=davem@davemloft.net \
--cc=ecree.xilinx@gmail.com \
--cc=edumazet@google.com \
--cc=gal@nvidia.com \
--cc=horms@kernel.org \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=jianbol@nvidia.com \
--cc=kory.maincent@bootlin.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=przemyslaw.kitszel@intel.com \
--cc=willemb@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox