[PATCH v1 01/18] staging: gpib: struct typing for gpib_interface

Michael Rubin
2025-04-08T22:25:10Z

Using Linux code style for gpib_interface struct in .h to allow drivers to
migrate.

Adhering to Linux code style.

In general, a pointer, or a struct that has elements that can reasonably be
directly accessed should never be a typedef.

Reported by CheckPatch

WARNING: do not add new typedefs

Signed-off-by: Michael Rubin <matchstick@neverthere.org>
---
drivers/staging/gpib/include/gpib_types.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/staging/gpib/include/gpib_types.h b/drivers/staging/gpib/include/gpib_types.h
index 2d9b9be683f8..10d8776ef425 100644
--- a/drivers/staging/gpib/include/gpib_types.h
+++ b/drivers/staging/gpib/include/gpib_types.h
@@ -22,7 +22,7 @@
#include <linux/timer.h>
#include <linux/interrupt.h>

-typedef struct gpib_interface_struct gpib_interface_t;
+typedef struct gpib_interface gpib_interface_t;
struct gpib_board;

/* config parameters that are only used by driver attach functions */
@@ -51,7 +51,7 @@ typedef struct {
char *serial_number;
} gpib_board_config_t;

-struct gpib_interface_struct {
+struct gpib_interface {
/* name of board */
char *name;
/* attach() initializes board and allocates resources */
--
2.43.0