From: Florian Westphal <fw@strlen.de>
To: lvxiafei <xiafei_xupt@163.com>
Cc: coreteam@netfilter.org, davem@davemloft.net, edumazet@google.com,
horms@kernel.org, kadlec@netfilter.org, kuba@kernel.org,
linux-kernel@vger.kernel.org, lvxiafei@sensetime.com,
netdev@vger.kernel.org, netfilter-devel@vger.kernel.org,
pabeni@redhat.com, pablo@netfilter.org
Subject: Re: [PATCH V3] netfilter: netns nf_conntrack: per-netns net.netfilter.nf_conntrack_max sysctl
Date: Wed, 9 Apr 2025 09:20:28 +0200 [thread overview]
Message-ID: <20250409072028.GA14003@breakpoint.cc> (raw)
In-Reply-To: <20250409042515.64578-1-xiafei_xupt@163.com>
lvxiafei <xiafei_xupt@163.com> wrote:
> - if (nf_conntrack_max && unlikely(ct_count > nf_conntrack_max)) {
> + if (net->ct.sysctl_max && unlikely(ct_count > min(nf_conntrack_max, net->ct.sysctl_max))) {
> if (!early_drop(net, hash)) {
> if (!conntrack_gc_work.early_drop)
> conntrack_gc_work.early_drop = true;
> diff --git a/net/netfilter/nf_conntrack_standalone.c b/net/netfilter/nf_conntrack_standalone.c
> index 2f666751c7e7..4a073c4de1b7 100644
> --- a/net/netfilter/nf_conntrack_standalone.c
> +++ b/net/netfilter/nf_conntrack_standalone.c
> @@ -615,7 +615,7 @@ enum nf_ct_sysctl_index {
> static struct ctl_table nf_ct_sysctl_table[] = {
> [NF_SYSCTL_CT_MAX] = {
> .procname = "nf_conntrack_max",
> - .data = &nf_conntrack_max,
> + .data = &init_net.ct.sysctl_max,
Whats the function of nf_conntrack_max?
After this change its always 0?
next prev parent reply other threads:[~2025-04-09 7:20 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-07 9:50 [PATCH] netfilter: netns nf_conntrack: per-netns net.netfilter.nf_conntrack_max sysctl lvxiafei
2025-04-07 10:13 ` Florian Westphal
2025-04-07 10:56 ` Jan Engelhardt
2025-04-08 8:27 ` lvxiafei
2025-04-08 8:38 ` lvxiafei
2025-04-08 8:17 ` lvxiafei
2025-04-08 9:03 ` [PATCH V2] " lvxiafei
2025-04-08 9:58 ` Florian Westphal
2025-04-08 12:39 ` lvxiafei
2025-04-08 13:28 ` Florian Westphal
2025-04-09 4:14 ` lvxiafei
2025-04-09 4:25 ` [PATCH V3] " lvxiafei
2025-04-09 7:20 ` Florian Westphal [this message]
2025-04-09 9:13 ` lvxiafei
2025-04-09 9:42 ` Florian Westphal
2025-04-10 10:02 ` lvxiafei
2025-04-10 10:53 ` Florian Westphal
2025-04-10 13:05 ` lvxiafei
2025-04-10 13:17 ` Florian Westphal
2025-04-10 14:16 ` Florian Westphal
2025-04-11 4:09 ` lvxiafei
2025-04-12 14:37 ` [PATCH V4] " lvxiafei
2025-04-12 17:26 ` [PATCH V5] " lvxiafei
2025-04-12 17:30 ` lvxiafei
2025-04-12 21:16 ` Jakub Kicinski
2025-04-13 1:14 ` lvxiafei
2025-04-13 9:07 ` Florian Westphal
2025-04-14 3:04 ` lvxiafei
2025-04-15 9:08 ` [PATCH V6] " lvxiafei
2025-04-27 8:14 ` lvxiafei
2025-04-28 9:40 ` Pablo Neira Ayuso
2025-05-22 19:24 ` Pablo Neira Ayuso
2025-05-22 19:32 ` Florian Westphal
2025-05-22 19:58 ` Pablo Neira Ayuso
2025-05-23 9:21 ` lvxiafei
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250409072028.GA14003@breakpoint.cc \
--to=fw@strlen.de \
--cc=coreteam@netfilter.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=kadlec@netfilter.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lvxiafei@sensetime.com \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=pablo@netfilter.org \
--cc=xiafei_xupt@163.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).