From: Xi Pardee <xi.pardee@linux.intel.com>
To: xi.pardee@linux.intel.com, irenic.rajneesh@gmail.com,
david.e.box@linux.intel.com, hdegoede@redhat.com,
ilpo.jarvinen@linux.intel.com,
platform-driver-x86@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org
Subject: [PATCH v3 6/8] platform/x86:intel/pmc: Remove unneeded io operations
Date: Wed, 9 Apr 2025 12:10:48 -0700 [thread overview]
Message-ID: <20250409191056.15434-7-xi.pardee@linux.intel.com> (raw)
In-Reply-To: <20250409191056.15434-1-xi.pardee@linux.intel.com>
Remove ioremap and iounmap operations that are not needed. ioremap
and iounmap operations are handled by the caller of the pmc_add_pmt
function.
Signed-off-by: Xi Pardee <xi.pardee@linux.intel.com>
---
drivers/platform/x86/intel/pmc/ssram_telemetry.c | 6 ------
1 file changed, 6 deletions(-)
diff --git a/drivers/platform/x86/intel/pmc/ssram_telemetry.c b/drivers/platform/x86/intel/pmc/ssram_telemetry.c
index 10ead4398a68..7b8443092b20 100644
--- a/drivers/platform/x86/intel/pmc/ssram_telemetry.c
+++ b/drivers/platform/x86/intel/pmc/ssram_telemetry.c
@@ -36,13 +36,7 @@ pmc_add_pmt(struct pmc_dev *pmcdev, u64 ssram_base, void __iomem *ssram)
u32 dvsec_offset;
u32 table, hdr;
- ssram = ioremap(ssram_base, SSRAM_HDR_SIZE);
- if (!ssram)
- return;
-
dvsec_offset = readl(ssram + SSRAM_DVSEC_OFFSET);
- iounmap(ssram);
-
dvsec = ioremap(ssram_base + dvsec_offset, SSRAM_DVSEC_SIZE);
if (!dvsec)
return;
--
2.43.0
next prev parent reply other threads:[~2025-04-09 19:11 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-09 19:10 [PATCH v3 0/8] Create Intel PMC SSRAM Telemetry driver Xi Pardee
2025-04-09 19:10 ` [PATCH v3 1/8] platform/x86:intel/pmc: Move PMC Core related functions Xi Pardee
2025-04-10 12:23 ` Ilpo Järvinen
2025-04-09 19:10 ` [PATCH v3 2/8] platform/x86:intel/pmc: Rename core_ssram to ssram_telemetry Xi Pardee
2025-04-09 19:10 ` [PATCH v3 3/8] platform/x86:intel/pmc: Move PMC devid to core.h Xi Pardee
2025-04-09 19:10 ` [PATCH v3 4/8] platform/x86:intel/pmc: Convert index variables to be unsigned Xi Pardee
2025-04-09 19:10 ` [PATCH v3 5/8] platform/x86:intel/pmc: Remove unneeded header file inclusion Xi Pardee
2025-04-09 19:10 ` Xi Pardee [this message]
2025-04-09 19:10 ` [PATCH v3 7/8] platform/x86:intel/pmc: Create Intel PMC SSRAM Telemetry driver Xi Pardee
2025-04-11 13:00 ` Ilpo Järvinen
2025-04-15 18:34 ` Xi Pardee
2025-04-09 19:10 ` [PATCH v3 8/8] platform/x86:intel/pmc: Move error handling to init function Xi Pardee
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250409191056.15434-7-xi.pardee@linux.intel.com \
--to=xi.pardee@linux.intel.com \
--cc=david.e.box@linux.intel.com \
--cc=hdegoede@redhat.com \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=irenic.rajneesh@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=platform-driver-x86@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox