From: Alex Elder <elder@riscstar.com>
To: gregkh@linuxfoundation.org, jirislaby@kernel.org,
robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org
Cc: dlan@gentoo.org, benjamin.larsson@genexis.eu,
bastien.curutchet@bootlin.com, andriy.shevchenko@linux.intel.com,
u.kleine-koenig@baylibre.com, lkundrak@v3.sk,
devicetree@vger.kernel.org, linux-serial@vger.kernel.org,
spacemit@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: [PATCH v2 2/2] serial: 8250_of: add support for an optional bus clock
Date: Wed, 9 Apr 2025 14:22:12 -0500 [thread overview]
Message-ID: <20250409192213.1130181-3-elder@riscstar.com> (raw)
In-Reply-To: <20250409192213.1130181-1-elder@riscstar.com>
The SpacemiT UART requires a bus clock to be enabled, in addition to
it's "normal" core clock. Look up the optional bus clock by name,
and if that's found, look up the core clock using the name "core".
Supplying a bus clock is optional. If no bus clock is needed, the
the first/only clock is used for the core clock.
Signed-off-by: Alex Elder <elder@riscstar.com>
---
v2: Update logic to more check for the optional bus clock first
drivers/tty/serial/8250/8250_of.c | 11 ++++++++++-
1 file changed, 10 insertions(+), 1 deletion(-)
diff --git a/drivers/tty/serial/8250/8250_of.c b/drivers/tty/serial/8250/8250_of.c
index 11c860ea80f60..a90a5462aa72a 100644
--- a/drivers/tty/serial/8250/8250_of.c
+++ b/drivers/tty/serial/8250/8250_of.c
@@ -123,7 +123,16 @@ static int of_platform_serial_setup(struct platform_device *ofdev,
/* Get clk rate through clk driver if present */
if (!port->uartclk) {
- info->clk = devm_clk_get_enabled(dev, NULL);
+ struct clk *bus_clk;
+
+ bus_clk = devm_clk_get_optional_enabled(dev, "bus");
+ if (IS_ERR(bus_clk)) {
+ ret = dev_err_probe(dev, PTR_ERR(bus_clk), "failed to get bus clock\n");
+ goto err_pmruntime;
+ }
+
+ /* If the bus clock is required, core clock must be named */
+ info->clk = devm_clk_get_enabled(dev, bus_clk ? "core" : NULL);
if (IS_ERR(info->clk)) {
ret = dev_err_probe(dev, PTR_ERR(info->clk), "failed to get clock\n");
goto err_pmruntime;
--
2.45.2
next prev parent reply other threads:[~2025-04-09 19:22 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-09 19:22 [PATCH v2 0/2] serial: 8250_of: support an optional bus clock Alex Elder
2025-04-09 19:22 ` [PATCH v2 1/2] dt-bindings: serial: 8250: support an optional second clock Alex Elder
2025-04-10 13:01 ` Rob Herring (Arm)
2025-04-09 19:22 ` Alex Elder [this message]
2025-04-09 21:43 ` [PATCH v2 2/2] serial: 8250_of: add support for an optional bus clock Yixun Lan
2025-04-09 22:47 ` Alex Elder
2025-04-09 23:59 ` Yixun Lan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250409192213.1130181-3-elder@riscstar.com \
--to=elder@riscstar.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=bastien.curutchet@bootlin.com \
--cc=benjamin.larsson@genexis.eu \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dlan@gentoo.org \
--cc=gregkh@linuxfoundation.org \
--cc=jirislaby@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=lkundrak@v3.sk \
--cc=robh@kernel.org \
--cc=spacemit@lists.linux.dev \
--cc=u.kleine-koenig@baylibre.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox