From: Kuniyuki Iwashima <kuniyu@amazon.com>
To: <zijun_hu@icloud.com>
Cc: <dada1@cosmosbay.com>, <davem@davemloft.net>,
<edumazet@google.com>, <horms@kernel.org>, <kuba@kernel.org>,
<kuniyu@amazon.com>, <linux-kernel@vger.kernel.org>,
<netdev@vger.kernel.org>, <pabeni@redhat.com>,
<quic_zijuhu@quicinc.com>, <willemb@google.com>,
<xemul@openvz.org>
Subject: Re: [PATCH net-next v2] sock: Correct error checking condition for (assign|release)_proto_idx()
Date: Wed, 9 Apr 2025 20:53:26 -0700 [thread overview]
Message-ID: <20250410035328.23034-1-kuniyu@amazon.com> (raw)
In-Reply-To: <20250410-fix_net-v2-1-d69e7c5739a4@quicinc.com>
> [PATCH net-next v2] sock: Correct error checking condition for (assign|release)_proto_idx()
Maybe net instead of net-next ?
From: Zijun Hu <zijun_hu@icloud.com>
Date: Thu, 10 Apr 2025 09:01:27 +0800
> From: Zijun Hu <quic_zijuhu@quicinc.com>
>
> (assign|release)_proto_idx() wrongly check find_first_zero_bit() failure
> by condition '(prot->inuse_idx == PROTO_INUSE_NR - 1)' obviously.
>
> Fix by correcting the condition to '(prot->inuse_idx == PROTO_INUSE_NR)'
>
> Fixes: 13ff3d6fa4e6 ("[SOCK]: Enumerate struct proto-s to facilitate percpu inuse accounting (v2).")
> Signed-off-by: Zijun Hu <quic_zijuhu@quicinc.com>
Reviewed-by: Kuniyuki Iwashima <kuniyu@amazon.com>
next prev parent reply other threads:[~2025-04-10 3:53 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-10 1:01 [PATCH net-next v2] sock: Correct error checking condition for (assign|release)_proto_idx() Zijun Hu
2025-04-10 3:53 ` Kuniyuki Iwashima [this message]
2025-04-10 8:04 ` Eric Dumazet
2025-04-10 10:47 ` Zijun Hu
2025-04-11 23:40 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250410035328.23034-1-kuniyu@amazon.com \
--to=kuniyu@amazon.com \
--cc=dada1@cosmosbay.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=quic_zijuhu@quicinc.com \
--cc=willemb@google.com \
--cc=xemul@openvz.org \
--cc=zijun_hu@icloud.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox