From: Jason Gunthorpe <jgg@ziepe.ca>
To: "Tian, Kevin" <kevin.tian@intel.com>
Cc: Robin Murphy <robin.murphy@arm.com>,
Fedor Pchelkin <pchelkin@ispras.ru>,
Joerg Roedel <joro@8bytes.org>, Will Deacon <will@kernel.org>,
Nicolin Chen <nicolinc@nvidia.com>,
"iommu@lists.linux.dev" <iommu@lists.linux.dev>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"lvc-project@linuxtesting.org" <lvc-project@linuxtesting.org>
Subject: Re: [PATCH] iommu: fix crash in report_iommu_fault()
Date: Thu, 10 Apr 2025 10:00:06 -0300 [thread overview]
Message-ID: <20250410130006.GD1727154@ziepe.ca> (raw)
In-Reply-To: <BN9PR11MB527618FFDCF2D7287C3ACA028CB72@BN9PR11MB5276.namprd11.prod.outlook.com>
On Thu, Apr 10, 2025 at 05:29:51AM +0000, Tian, Kevin wrote:
> It sounds a general requirement to all IOMMU drivers, but in reality
> only a subset of iommu drivers call it (e.g. intel/smmuv3 don't). So
> there seems to be an implicit assumption from drivers on whether
> the underlying IOMMU provides such facility...
Yeah, it's a bit wonky. And a different intersection calls the new
fault handling API instead :\
There are only 3 things using iommu_set_fault_handler():
- drivers/gpu/drm/msm
Seems to actually do restartable page faulting?? Maybe it needs to
move to the PRI API..
- drivers/infiniband/hw/usnic
This just prints a log, we should remove it
- drivers/remoteproc
This prints a log and does some crash_handler
I just quickly typed in a small series to improve on this..
Jason
next prev parent reply other threads:[~2025-04-10 13:00 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-08 21:33 [PATCH] iommu: fix crash in report_iommu_fault() Fedor Pchelkin
2025-04-08 21:38 ` Jason Gunthorpe
2025-04-09 11:30 ` Robin Murphy
2025-04-10 5:29 ` Tian, Kevin
2025-04-10 13:00 ` Jason Gunthorpe [this message]
2025-04-10 5:21 ` Tian, Kevin
2025-04-11 7:05 ` Joerg Roedel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250410130006.GD1727154@ziepe.ca \
--to=jgg@ziepe.ca \
--cc=iommu@lists.linux.dev \
--cc=joro@8bytes.org \
--cc=kevin.tian@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lvc-project@linuxtesting.org \
--cc=nicolinc@nvidia.com \
--cc=pchelkin@ispras.ru \
--cc=robin.murphy@arm.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox