From: Leon Romanovsky <leon@kernel.org>
To: Konstantin Taranov <kotaranov@microsoft.com>
Cc: Konstantin Taranov <kotaranov@linux.microsoft.com>,
"pabeni@redhat.com" <pabeni@redhat.com>,
Haiyang Zhang <haiyangz@microsoft.com>,
KY Srinivasan <kys@microsoft.com>,
"edumazet@google.com" <edumazet@google.com>,
"kuba@kernel.org" <kuba@kernel.org>,
"davem@davemloft.net" <davem@davemloft.net>,
Dexuan Cui <decui@microsoft.com>,
"wei.liu@kernel.org" <wei.liu@kernel.org>,
Long Li <longli@microsoft.com>, "jgg@ziepe.ca" <jgg@ziepe.ca>,
"linux-rdma@vger.kernel.org" <linux-rdma@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>
Subject: Re: [EXTERNAL] Re: [PATCH rdma-next 1/3] RDMA/mana_ib: Access remote atomic for MRs
Date: Thu, 10 Apr 2025 16:54:34 +0300 [thread overview]
Message-ID: <20250410135434.GT199604@unreal> (raw)
In-Reply-To: <PA1PR83MB0662535F57D8F09C1C99DDDAB4B72@PA1PR83MB0662.EURPRD83.prod.outlook.com>
On Thu, Apr 10, 2025 at 01:37:00PM +0000, Konstantin Taranov wrote:
> > > @@ -24,6 +24,9 @@ mana_ib_verbs_to_gdma_access_flags(int
> > access_flags)
> > > if (access_flags & IB_ACCESS_REMOTE_READ)
> > > flags |= GDMA_ACCESS_FLAG_REMOTE_READ;
> > >
> > > + if (access_flags & IB_ACCESS_REMOTE_ATOMIC)
> > > + flags |= GDMA_ACCESS_FLAG_REMOTE_ATOMIC;
> >
> > Can you enable this flag unconditionally without relation to running RW?
>
> Yes, ATOMIC access does not depend on Remote Read and Remote Write.
The question is "do you have FW which doesn't support
GDMA_ACCESS_FLAG_REMOTE_ATOMIC? and what will happen if such flag used
for such FW?"
> I also do not see any conditions in other drivers.
At least for mlx5, we are checking FW capability if it is supported.
See get_unchangeable_access_flags().
>
> - Konstantin
>
> >
> > Thanks
> >
> > > +
> > > return flags;
> > > }
> > >
> > > --
> > > 2.43.0
> > >
next prev parent reply other threads:[~2025-04-10 13:54 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-04 14:45 [PATCH rdma-next 0/3] RDMA/mana_ib: extend MR support Konstantin Taranov
2025-04-04 14:45 ` [PATCH rdma-next 1/3] RDMA/mana_ib: Access remote atomic for MRs Konstantin Taranov
2025-04-09 12:28 ` Leon Romanovsky
2025-04-10 13:37 ` [EXTERNAL] " Konstantin Taranov
2025-04-10 13:54 ` Leon Romanovsky [this message]
2025-04-14 9:15 ` Konstantin Taranov
2025-04-04 14:45 ` [PATCH rdma-next 2/3] RDMA/mana_ib: support of the zero based MRs Konstantin Taranov
2025-04-04 14:45 ` [PATCH rdma-next 3/3] RDMA/mana_ib: Add support of 4M, 1G, and 2G pages Konstantin Taranov
2025-04-09 12:27 ` Leon Romanovsky
2025-04-10 13:38 ` [EXTERNAL] " Konstantin Taranov
2025-04-10 13:55 ` Leon Romanovsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250410135434.GT199604@unreal \
--to=leon@kernel.org \
--cc=davem@davemloft.net \
--cc=decui@microsoft.com \
--cc=edumazet@google.com \
--cc=haiyangz@microsoft.com \
--cc=jgg@ziepe.ca \
--cc=kotaranov@linux.microsoft.com \
--cc=kotaranov@microsoft.com \
--cc=kuba@kernel.org \
--cc=kys@microsoft.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=longli@microsoft.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=wei.liu@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).