From: Arnd Bergmann <arnd@kernel.org>
To: Mark Brown <broonie@kernel.org>,
Raju Rangoju <Raju.Rangoju@amd.com>,
Akshata MukundShetty <akshata.mukundshetty@amd.com>,
Krishnamoorthi M <krishnamoorthi.m@amd.com>
Cc: Arnd Bergmann <arnd@arndb.de>,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
Nuno Sa <nuno.sa@analog.com>,
Jonathan Cameron <Jonathan.Cameron@huawei.com>,
David Lechner <dlechner@baylibre.com>,
linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH] spi: amd: add CONFIG_PCI dependency
Date: Thu, 10 Apr 2025 16:07:49 +0200 [thread overview]
Message-ID: <20250410140809.812863-1-arnd@kernel.org> (raw)
From: Arnd Bergmann <arnd@arndb.de>
Without CONFIG_PCI, the module_pci_driver() macro is not defined:
drivers/spi/spi-amd-pci.c:67:1: error: type specifier missing, defaults to 'int'; ISO C99 and later do not support implicit int [-Wimplicit-int]
67 | module_pci_driver(amd_spi_pci_driver);
Fixes: b644c2776652 ("spi: spi_amd: Add PCI-based driver for AMD HID2 SPI controller")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
drivers/spi/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/spi/Kconfig b/drivers/spi/Kconfig
index 52598f8e7848..b2f5b29980a2 100644
--- a/drivers/spi/Kconfig
+++ b/drivers/spi/Kconfig
@@ -1266,6 +1266,7 @@ config SPI_ZYNQMP_GQSPI
config SPI_AMD
tristate "AMD SPI controller"
+ depends on PCI
depends on SPI_MASTER || COMPILE_TEST
help
Enables SPI controller driver for AMD SoC.
--
2.39.5
next reply other threads:[~2025-04-10 14:08 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-10 14:07 Arnd Bergmann [this message]
2025-04-11 0:54 ` [PATCH] spi: amd: add CONFIG_PCI dependency Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250410140809.812863-1-arnd@kernel.org \
--to=arnd@kernel.org \
--cc=Jonathan.Cameron@huawei.com \
--cc=Raju.Rangoju@amd.com \
--cc=akshata.mukundshetty@amd.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=arnd@arndb.de \
--cc=broonie@kernel.org \
--cc=dlechner@baylibre.com \
--cc=krishnamoorthi.m@amd.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=nuno.sa@analog.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox