[PATCH] regulator: adp5055: remove duplicate device table

[PATCH] regulator: adp5055: remove duplicate device table

[Arnd Bergmann]

From: Arnd Bergmann <arnd@arndb.de>

When building with -Wunused-const-variable, gcc points out an
device table that is not referenced anywhere:

drivers/regulator/adp5055-regulator.c:346:34: error: unused variable 'adp5055_dt_ids' [-Werror,-Wunused-const-variable]
  346 | static const struct of_device_id adp5055_dt_ids[] = {
      |                                  ^~~~~~~~~~~~~~

The contents are the same as the second table in that file, so
just remove this copy.

Fixes: 147b2a96f24e ("regulator: adp5055: Add driver for adp5055")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
 drivers/regulator/adp5055-regulator.c | 6 ------
 1 file changed, 6 deletions(-)

diff --git a/drivers/regulator/adp5055-regulator.c b/drivers/regulator/adp5055-regulator.c
index ad8e42cb1f3f..59648499196f 100644
--- a/drivers/regulator/adp5055-regulator.c
+++ b/drivers/regulator/adp5055-regulator.c
@@ -343,12 +343,6 @@ static struct regulator_desc adp5055_regulators[] = {
 	ADP5055_REG("buck2", 2, 2),
 };
 
-static const struct of_device_id adp5055_dt_ids[] = {
-	{ .compatible = "adi,adp5055"},
-	{ }
-};
-MODULE_DEVICE_TABLE(of, adp5055_dt_ids);
-
 static int adp5055_probe(struct i2c_client *client)
 {
 	struct regulator_init_data *init_data;
-- 
2.39.5

Re: [PATCH] regulator: adp5055: remove duplicate device table

[Mark Brown]

On Thu, 10 Apr 2025 16:09:58 +0200, Arnd Bergmann wrote:
> When building with -Wunused-const-variable, gcc points out an
> device table that is not referenced anywhere:
> 
> drivers/regulator/adp5055-regulator.c:346:34: error: unused variable 'adp5055_dt_ids' [-Werror,-Wunused-const-variable]
>   346 | static const struct of_device_id adp5055_dt_ids[] = {
>       |                                  ^~~~~~~~~~~~~~
> 
> [...]

Applied to

   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/regulator.git for-next

Thanks!

[1/1] regulator: adp5055: remove duplicate device table
      commit: 28cce24d6596a3d8a34689031f2a8a5ac918cde5

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark