public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
To: Shrikanth Hegde <sshegde@linux.ibm.com>
Cc: linux-kernel@vger.kernel.org,
	"André Almeida" <andrealmeid@igalia.com>,
	"Darren Hart" <dvhart@infradead.org>,
	"Davidlohr Bueso" <dave@stgolabs.net>,
	"Ingo Molnar" <mingo@redhat.com>,
	"Juri Lelli" <juri.lelli@redhat.com>,
	"Peter Zijlstra" <peterz@infradead.org>,
	"Thomas Gleixner" <tglx@linutronix.de>,
	"Valentin Schneider" <vschneid@redhat.com>,
	"Waiman Long" <longman@redhat.com>,
	"Liang, Kan" <kan.liang@linux.intel.com>,
	"Adrian Hunter" <adrian.hunter@intel.com>,
	"Alexander Shishkin" <alexander.shishkin@linux.intel.com>,
	"Arnaldo Carvalho de Melo" <acme@kernel.org>,
	"Ian Rogers" <irogers@google.com>, "Jiri Olsa" <jolsa@kernel.org>,
	"Mark Rutland" <mark.rutland@arm.com>,
	"Namhyung Kim" <namhyung@kernel.org>,
	linux-perf-users@vger.kernel.org
Subject: Re: [PATCH v11 19/19] futex: Allow to make the private hash immutable.
Date: Thu, 10 Apr 2025 17:28:41 +0200	[thread overview]
Message-ID: <20250410152841.KypBTUMq@linutronix.de> (raw)
In-Reply-To: <ced9c08c-a017-495f-978b-0c4d13992e5e@linux.ibm.com>

On 2025-04-10 20:22:08 [+0530], Shrikanth Hegde wrote:
> Hi Sebastian.
Hi Shrikanth,

> It would be good option for the application to decide if it needs this.

You mean to have it as I introduced it here or something else?

> Using this option makes the perf regression goes away using previous number of buckets.

Okay, good to know. You test this on on ppc64le?

> Acked-by: Shrikanth Hegde <sshegde@linux.ibm.com>
> 
> base:
> ./perf bench futex hash
> Averaged 1556023 operations/sec (+- 0.08%), total secs = 10  <<-- 1.5M
> 
> with series:
> ./perf bench futex hash -b32768
> Averaged 126499 operations/sec (+- 0.41%), total secs = 10   <<-- .12M
> 
> ./perf bench futex hash -Ib32768
> Averaged 1549339 operations/sec (+- 0.08%), total secs = 10  <<-- 1.5M
Thank you for testing.
…
> nit: Does it makes sense to split this patch into futex and perf?

First I wanted to figure if we really do this. I have no idea if this
regression would show up in real world use case or just here as part of
the micro benchmark.
And if we do this, it would probably make sense to have one perf patch
which introduces -b & -I.  And then figure out if the additional option
to prctl should be part of the resize patch or not. Probably we should
enforce 0/1 of arg4 from the beginning so maybe folding this in makes
sense.

Sebastian

  reply	other threads:[~2025-04-10 15:28 UTC|newest]

Thread overview: 31+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-04-07 15:57 [PATCH v11 00/19] futex: Add support task local hash maps, FUTEX2_NUMA and FUTEX2_MPOL Sebastian Andrzej Siewior
2025-04-07 15:57 ` [PATCH v11 01/19] rcuref: Provide rcuref_is_dead() Sebastian Andrzej Siewior
2025-04-07 15:57 ` [PATCH v11 02/19] mm: Add vmalloc_huge_node() Sebastian Andrzej Siewior
2025-04-07 15:57 ` [PATCH v11 03/19] futex: Move futex_queue() into futex_wait_setup() Sebastian Andrzej Siewior
2025-04-07 15:57 ` [PATCH v11 04/19] futex: Pull futex_hash() out of futex_q_lock() Sebastian Andrzej Siewior
2025-04-07 15:57 ` [PATCH v11 05/19] futex: Create hb scopes Sebastian Andrzej Siewior
2025-04-07 15:57 ` [PATCH v11 06/19] futex: Create futex_hash() get/put class Sebastian Andrzej Siewior
2025-04-07 15:57 ` [PATCH v11 07/19] futex: Create private_hash() " Sebastian Andrzej Siewior
2025-04-07 15:57 ` [PATCH v11 08/19] futex: Acquire a hash reference in futex_wait_multiple_setup() Sebastian Andrzej Siewior
2025-04-07 15:57 ` [PATCH v11 09/19] futex: Decrease the waiter count before the unlock operation Sebastian Andrzej Siewior
2025-04-07 15:57 ` [PATCH v11 10/19] futex: Introduce futex_q_lockptr_lock() Sebastian Andrzej Siewior
2025-04-07 15:57 ` [PATCH v11 11/19] futex: Create helper function to initialize a hash slot Sebastian Andrzej Siewior
2025-04-07 15:57 ` [PATCH v11 12/19] futex: Add basic infrastructure for local task local hash Sebastian Andrzej Siewior
2025-04-07 15:57 ` [PATCH v11 13/19] futex: Allow automatic allocation of process wide futex hash Sebastian Andrzej Siewior
2025-04-07 15:57 ` [PATCH v11 14/19] futex: Allow to resize the private local hash Sebastian Andrzej Siewior
2025-04-07 15:57 ` [PATCH v11 15/19] futex: Implement FUTEX2_NUMA Sebastian Andrzej Siewior
2025-04-07 16:52   ` Sebastian Andrzej Siewior
2025-04-17 15:34     ` Sebastian Andrzej Siewior
2025-04-07 15:57 ` [PATCH v11 16/19] futex: Implement FUTEX2_MPOL Sebastian Andrzej Siewior
2025-04-07 15:57 ` [PATCH v11 17/19] tools headers: Synchronize prctl.h ABI header Sebastian Andrzej Siewior
2025-04-07 15:57 ` [PATCH v11 18/19] tools/perf: Allow to select the number of hash buckets Sebastian Andrzej Siewior
2025-04-07 15:57 ` [PATCH v11 19/19] futex: Allow to make the private hash immutable Sebastian Andrzej Siewior
2025-04-10 10:56   ` Sebastian Andrzej Siewior
2025-04-10 14:52   ` Shrikanth Hegde
2025-04-10 15:28     ` Sebastian Andrzej Siewior [this message]
2025-04-10 15:48       ` Shrikanth Hegde
2025-04-07 16:00 ` [PATCH v11 00/19] futex: Add support task local hash maps, FUTEX2_NUMA and FUTEX2_MPOL Sebastian Andrzej Siewior
2025-04-08 13:51 ` André Almeida
2025-04-08 16:13   ` Sebastian Andrzej Siewior
2025-04-10 17:51 ` Shrikanth Hegde
2025-04-15  9:03   ` Sebastian Andrzej Siewior

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250410152841.KypBTUMq@linutronix.de \
    --to=bigeasy@linutronix.de \
    --cc=acme@kernel.org \
    --cc=adrian.hunter@intel.com \
    --cc=alexander.shishkin@linux.intel.com \
    --cc=andrealmeid@igalia.com \
    --cc=dave@stgolabs.net \
    --cc=dvhart@infradead.org \
    --cc=irogers@google.com \
    --cc=jolsa@kernel.org \
    --cc=juri.lelli@redhat.com \
    --cc=kan.liang@linux.intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-perf-users@vger.kernel.org \
    --cc=longman@redhat.com \
    --cc=mark.rutland@arm.com \
    --cc=mingo@redhat.com \
    --cc=namhyung@kernel.org \
    --cc=peterz@infradead.org \
    --cc=sshegde@linux.ibm.com \
    --cc=tglx@linutronix.de \
    --cc=vschneid@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox