From: Ian Rogers <irogers@google.com>
To: Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@redhat.com>,
Arnaldo Carvalho de Melo <acme@kernel.org>,
Namhyung Kim <namhyung@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Jiri Olsa <jolsa@kernel.org>, Ian Rogers <irogers@google.com>,
Adrian Hunter <adrian.hunter@intel.com>,
Kan Liang <kan.liang@linux.intel.com>,
James Clark <james.clark@linaro.org>,
Dapeng Mi <dapeng1.mi@linux.intel.com>,
Thomas Richter <tmricht@linux.ibm.com>,
Veronika Molnarova <vmolnaro@redhat.com>,
Hao Ge <gehao@kylinos.cn>, Howard Chu <howardchu95@gmail.com>,
Weilin Wang <weilin.wang@intel.com>,
Levi Yun <yeoreum.yun@arm.com>,
"Dr. David Alan Gilbert" <linux@treblig.org>,
Dominique Martinet <asmadeus@codewreck.org>,
Xu Yang <xu.yang_2@nxp.com>,
Tengda Wu <wutengda@huaweicloud.com>,
linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org,
bpf@vger.kernel.org
Subject: [PATCH v2 01/12] perf tests record: Cleanup improvements
Date: Thu, 10 Apr 2025 10:36:20 -0700 [thread overview]
Message-ID: <20250410173631.1713627-2-irogers@google.com> (raw)
In-Reply-To: <20250410173631.1713627-1-irogers@google.com>
Remove the script output file. Add a trap debug message. Minor style
consistency changes.
Signed-off-by: Ian Rogers <irogers@google.com>
---
tools/perf/tests/shell/record.sh | 10 ++++++----
1 file changed, 6 insertions(+), 4 deletions(-)
diff --git a/tools/perf/tests/shell/record.sh b/tools/perf/tests/shell/record.sh
index ba8d873d3ca7..05d91a663fda 100755
--- a/tools/perf/tests/shell/record.sh
+++ b/tools/perf/tests/shell/record.sh
@@ -34,13 +34,15 @@ default_fd_limit=$(ulimit -Sn)
min_fd_limit=$(($(getconf _NPROCESSORS_ONLN) * 16))
cleanup() {
- rm -rf "${perfdata}"
- rm -rf "${perfdata}".old
+ rm -f "${perfdata}"
+ rm -f "${perfdata}".old
+ rm -f "${script_output}"
trap - EXIT TERM INT
}
trap_cleanup() {
+ echo "Unexpected signal in ${FUNCNAME[1]}"
cleanup
exit 1
}
@@ -239,7 +241,7 @@ test_leader_sampling() {
return
fi
index=0
- perf script -i "${perfdata}" > $script_output
+ perf script -i "${perfdata}" > "${script_output}"
while IFS= read -r line
do
# Check if the two instruction counts are equal in each record
@@ -252,7 +254,7 @@ test_leader_sampling() {
fi
index=$(($index+1))
prev_cycles=$cycles
- done < $script_output
+ done < "${script_output}"
echo "Basic leader sampling test [Success]"
}
--
2.49.0.604.gff1f9ca942-goog
next prev parent reply other threads:[~2025-04-10 17:36 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-10 17:36 [PATCH v2 00/12] Move uid filtering to BPF filters Ian Rogers
2025-04-10 17:36 ` Ian Rogers [this message]
2025-04-10 17:36 ` [PATCH v2 02/12] perf bench evlist-open-close: Reduce scope of 2 variables Ian Rogers
2025-04-10 17:36 ` [PATCH v2 03/12] perf parse-events filter: Use evsel__find_pmu Ian Rogers
2025-04-10 17:36 ` [PATCH v2 04/12] perf target: Separate parse_uid into its own function Ian Rogers
2025-04-10 17:36 ` [PATCH v2 05/12] perf parse-events: Add parse_uid_filter helper Ian Rogers
2025-04-10 17:36 ` [PATCH v2 06/12] perf record: Switch user option to use BPF filter Ian Rogers
2025-04-24 21:35 ` Arnaldo Carvalho de Melo
2025-04-10 17:36 ` [PATCH v2 07/12] perf tests record: Add basic uid filtering test Ian Rogers
2025-04-10 17:36 ` [PATCH v2 08/12] perf top: Switch user option to use BPF filter Ian Rogers
2025-04-10 17:36 ` [PATCH v2 09/12] perf trace: " Ian Rogers
2025-04-10 17:36 ` [PATCH v2 10/12] perf bench evlist-open-close: " Ian Rogers
2025-04-10 17:36 ` [PATCH v2 11/12] perf target: Remove uid from target Ian Rogers
2025-04-10 17:36 ` [PATCH v2 12/12] perf thread_map: Remove uid options Ian Rogers
2025-04-24 20:25 ` [PATCH v2 00/12] Move uid filtering to BPF filters Ian Rogers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250410173631.1713627-2-irogers@google.com \
--to=irogers@google.com \
--cc=acme@kernel.org \
--cc=adrian.hunter@intel.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=asmadeus@codewreck.org \
--cc=bpf@vger.kernel.org \
--cc=dapeng1.mi@linux.intel.com \
--cc=gehao@kylinos.cn \
--cc=howardchu95@gmail.com \
--cc=james.clark@linaro.org \
--cc=jolsa@kernel.org \
--cc=kan.liang@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=linux@treblig.org \
--cc=mark.rutland@arm.com \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
--cc=tmricht@linux.ibm.com \
--cc=vmolnaro@redhat.com \
--cc=weilin.wang@intel.com \
--cc=wutengda@huaweicloud.com \
--cc=xu.yang_2@nxp.com \
--cc=yeoreum.yun@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox