public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Christian Brauner <brauner@kernel.org>
To: Oleg Nesterov <oleg@redhat.com>
Cc: linux-fsdevel@vger.kernel.org, Jeff Layton <jlayton@kernel.org>,
	 Lennart Poettering <lennart@poettering.net>,
	 Daan De Meyer <daan.j.demeyer@gmail.com>,
	Mike Yuan <me@yhndnzj.com>,
	 linux-kernel@vger.kernel.org,
	Peter Ziljstra <peterz@infradead.org>,
	 Christian Brauner <brauner@kernel.org>
Subject: [PATCH v2 0/2] pidfs: ensure consistent ENOENT/ESRCH reporting
Date: Fri, 11 Apr 2025 15:22:43 +0200	[thread overview]
Message-ID: <20250411-work-pidfs-enoent-v2-0-60b2d3bb545f@kernel.org> (raw)

In a prior patch series we tried to cleanly differentiate between:

(1) The task has already been reaped.
(2) The caller requested a pidfd for a thread-group leader but the pid
actually references a struct pid that isn't used as a thread-group
leader.

as this was causing issues for non-threaded workloads.

But there's cases where the current simple logic is wrong. Specifically,
if the pid was a leader pid and the check races with __unhash_process().
Stabilize this by using the pidfd waitqueue lock.

Signed-off-by: Christian Brauner <brauner@kernel.org>
---
Christian Brauner (2):
      exit: move wake_up_all() pidfd waiters into __unhash_process()
      pidfs: ensure consistent ENOENT/ESRCH reporting

 kernel/exit.c |  5 +++++
 kernel/fork.c | 31 +++++++++++++------------------
 kernel/pid.c  |  5 -----
 3 files changed, 18 insertions(+), 23 deletions(-)
---
base-commit: 1e940fff94374d04b6c34f896ed9fbad3d2fb706
change-id: 20250411-work-pidfs-enoent-747579160c8c


             reply	other threads:[~2025-04-11 13:22 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-04-11 13:22 Christian Brauner [this message]
2025-04-11 13:22 ` [PATCH v2 1/2] exit: move wake_up_all() pidfd waiters into __unhash_process() Christian Brauner
2025-04-11 13:22 ` [PATCH v2 2/2] pidfs: ensure consistent ENOENT/ESRCH reporting Christian Brauner
2025-04-11 13:54   ` Oleg Nesterov
2025-04-11 15:14     ` Christian Brauner
2025-04-11 15:28       ` Oleg Nesterov
2025-04-15 22:34 ` [PATCH v2 0/2] " Nathan Chancellor
2025-04-16 13:55   ` Christian Brauner
2025-04-16 19:47     ` Christian Brauner
2025-04-16 20:21       ` Christian Brauner
2025-04-16 21:15         ` Nathan Chancellor

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250411-work-pidfs-enoent-v2-0-60b2d3bb545f@kernel.org \
    --to=brauner@kernel.org \
    --cc=daan.j.demeyer@gmail.com \
    --cc=jlayton@kernel.org \
    --cc=lennart@poettering.net \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=me@yhndnzj.com \
    --cc=oleg@redhat.com \
    --cc=peterz@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox