From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 046E427E1B0; Fri, 11 Apr 2025 21:18:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744406329; cv=none; b=huMp5JmJIUZshtR0P1mh5g4348rUyUOJJWvs9lrIou9dN3PsdaxBzj+9L5SjAb/ll6K3MOOw7BE5tnR4L5mHRm2Ls06FP2H1WLd6Eco5nGnKa52atsNAMgnbdbrRZMzCTEbWY+A8G3hTwzyhwKTQ3wNGp+lWDaKdCh1cBueSQII= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744406329; c=relaxed/simple; bh=0+8SOdZHpARtPKiOteQjtALkLBWbvVG2+mmUnczmE6k=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=d6OGRHvAmDcEZTqfbsVk5u6UEdu5/88SBoS201eV1hiqJdBng6PofYkMAo+g2Ql1a8x7z/H8HTxOYvvbnJ9a59f/ZJ+x5esHa9QwiygKJICilEQBpIuChUUMDlHYCmX0Un9t+c5RQR34l/6Wgwx7wcaumeNV+/99UCWrLKYT2V0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=eUSYJRts; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="eUSYJRts" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 05D44C4CEE2; Fri, 11 Apr 2025 21:18:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1744406328; bh=0+8SOdZHpARtPKiOteQjtALkLBWbvVG2+mmUnczmE6k=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=eUSYJRtsz0gqNFUtQzmCGPrW/hjcU/fV1v3EUKrVUCHeUHQCF/QhOeSNGADnYl+aC PdCzw4h+2c365BC1VVrAw2Yg6TL1HTZ7RX1k0NYkuIiHho3+wwCRrAXYU13v985kNe RAS/tmcJ60mcCO/54quTUZQckfa/7TqfVu+sb10hwxmHQYY3+aCVANq4exr2vvon/0 JXgFRdC9/3cEs7Ro7mHv48ny5inlbk1y4xWKH1sJZ0xt4zLxUXpom4OdOwOR7/5QNI f226gcwTSS68TrnwJAfyhhpTdjeimOAT5vu+ycF7BstGAXE0OJePO+I8jRsQwr8Fcn Jlby+osCVN8kA== Date: Fri, 11 Apr 2025 14:18:47 -0700 From: Jakub Kicinski To: Sabrina Dubroca Cc: Antonio Quartulli , netdev@vger.kernel.org, Eric Dumazet , Paolo Abeni , Donald Hunter , Shuah Khan , ryazanov.s.a@gmail.com, Andrew Lunn , Simon Horman , linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org, Xiao Liang , steffen.klassert@secunet.com, antony.antony@secunet.com Subject: Re: [PATCH net-next v25 01/23] net: introduce OpenVPN Data Channel Offload (ovpn) Message-ID: <20250411141847.6dba6987@kernel.org> In-Reply-To: References: <20250407-b4-ovpn-v25-0-a04eae86e016@openvpn.net> <20250407-b4-ovpn-v25-1-a04eae86e016@openvpn.net> <20250410195440.3ba7ba0f@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Fri, 11 Apr 2025 15:50:49 +0200 Sabrina Dubroca wrote: > > My understanding is that this is the standard approach to: > > 1) hook in the middle of registration/deregistration; > > 2) handle events generated by other components/routines. > > > > I see in /drivers/net/ almost every driver registers a notifier for their > > own device. > > I think most of them register a notifier for their lower device > (bridge port, real device under a vlan, or similar). > > I've mentioned at some point that it would be more usual to replace > this notifier with a custom dellink, and that ovpn->registered could > likely be replaced with checking for NETREG_REGISTERED. I just thought > it could be cleaned up a bit later, but it seems Jakub wants it done > before taking the patches :) Ideally, yes. One fewer place for us to check when trying to figure out if we will break anything with the locking changes :( Notifiers are very powerful but that comes at high maintenance cost.