Re: [PATCH v8 17/21] x86,fs/resctrl: Move the resctrl filesystem code to live in /fs/resctrl

Reinette Chatre
2025-04-14T23:30:01Z

Hi Fenghua,

On 4/14/25 4:22 PM, Fenghua Yu wrote:
> Hi, Reinette,
>
> On 4/14/25 09:04, Reinette Chatre wrote:
>> Hi Fenghua,
>>
>> On 4/11/25 5:18 PM, Fenghua Yu wrote:
>>
>>>>    arch/x86/kernel/cpu/resctrl/ctrlmondata.c     |  636 ---
>>>>    arch/x86/kernel/cpu/resctrl/internal.h        |  380 +-
>>>>    arch/x86/kernel/cpu/resctrl/monitor.c         |  902 +---
>>>>    arch/x86/kernel/cpu/resctrl/monitor_trace.h   |   18 +-
>>>>    arch/x86/kernel/cpu/resctrl/pseudo_lock.c     | 1080 +---
>>>>    .../kernel/cpu/resctrl/pseudo_lock_trace.h    |    2 +
>>>>    arch/x86/kernel/cpu/resctrl/rdtgroup.c        | 4556 +----------------
>>>>    fs/resctrl/ctrlmondata.c                      |  660 +++
>>>>    fs/resctrl/internal.h                         |  442 ++
>>>>    fs/resctrl/monitor.c                          |  932 ++++
>>>>    fs/resctrl/monitor_trace.h                    |   33 +
>>>>    fs/resctrl/pseudo_lock.c                      | 1115 ++++
>>>>    fs/resctrl/pseudo_lock_trace.h                |   17 +
>>>>    fs/resctrl/rdtgroup.c                         | 4313 ++++++++++++++++
>>>>    14 files changed, 7668 insertions(+), 7418 deletions(-)
>> This patch is huge. Placing a response in the middle of it makes your feedback
>> very hard to find. Please trim your replies.
>>
>> Reinette
>>
>>
> You are right! I re-sent my comment and remove all irrelevant code. Now hopefully it's easier to see my comment:)
>

Thank you very much for re-sending the trimmed version. This helps a lot.

Reinette