Re: [PATCH v8 00/21] x86/resctrl: Move the resctrl filesystem code to /fs/resctrl

James Morse
2025-04-24T17:12:36Z

Hi Tony,

On 15/04/2025 19:48, Luck, Tony wrote:
> On Fri, Apr 11, 2025 at 04:42:08PM +0000, James Morse wrote:
>> Changes since v7:
>> * Switched to Tony's alternative for having a structure behind struct
>> mon_data.
>>
>> Changes otherwise noted on each patch.
>>
>> N.B, the disk in my machine recently died - so I've re-done the feedback
>> changes multiple times. Appologies if I missed something on the second pass!
>> ---
>> Patch 1 has been posted as a fix that should get picked up independently.
>>
>> Patches X-Y should be squashed together when merged - they are posted like

> X=17 (the big move). Y=20 (last of the cleanups from the move)?

Probably 21 as well as that is mechanical changes as part of the move.

>> this to allow folk to re-generate patch N, then review the differences on
>> top. Not squashing them together would expose a ftrace build warning
>> during bisect. (but who does that!)
>> That would look like this:
>> git://git.kernel.org/pub/scm/linux/kernel/git/morse/linux.git mpam/move_to_fs/v8_final

> This "final" branch is missing the patch that move resctrl.rst into
> Documentation/filesystems.

Right - sorry I cut it in the wrong place. I've have loads of MPAM driver on top...

Hopefully it illustrates my suggestion for reviewing/merging...

>> This series is based on rc1, and can be retrieved from:
>> git://git.kernel.org/pub/scm/linux/kernel/git/morse/linux.git mpam/move_to_fs/v8
>>
>> This series renames functions and moves code around. With the
>> exception of invalid configurations for the configurable-events, there should
>> be no changes in behaviour caused by this series. It is now possible for
>> throttle_mode to report 'undefined', but no known platform will do this.
>
> As far as I can tell x86/Intel systems are still working as before.
>
>> The driving pattern is to make things like struct rdtgroup private to resctrl.
>> Features like pseudo-lock aren't going to work on arm64, the ability to disable
>> it at compile time is added.
>>
>> After this, I can start posting the MPAM driver to make use of resctrl on arm64.
>> (What's MPAM? See the cover letter of the first series. [1])
>>
>> As ever - bugs welcome,
>
> Couldn't find any bugs for you.

:(

Thanks for taking a look!

James