RE: [PATCH v8 09/21] x86/resctrl: Remove a newline to avoid confusing the code move script

Shaopeng Tan (Fujitsu)
2025-04-25T02:33:41Z

Hello
> The resctrl filesystem code will shortly be moved to /fs/. This involves splitting
> all the existing files, with some functions remaining under arch/x86, and others
> moving to fs/resctrl.
>
> To make this reproducible, a python script does the heavy lif^W
> copy-and-paste. This involves some clunky parsing of C code.
Is "lif^W" a typo?

Best regards,
Shaopeng TAN

> The parser gets confused by the newline after this #ifdef.
> Just remove it.
>
> Signed-off-by: James Morse <james.morse@arm.com>
> Tested-by: Carl Worth <carl@os.amperecomputing.com> # arm64
> Tested-by: Shaopeng Tan <tan.shaopeng@jp.fujitsu.com>
> Tested-by: Peter Newman <peternewman@google.com>
> Tested-by: Amit Singh Tomar <amitsinght@marvell.com> # arm64
> Tested-by: Shanker Donthineni <sdonthineni@nvidia.com> # arm64
> Tested-by: Babu Moger <babu.moger@amd.com>
> Reviewed-by: Shaopeng Tan <tan.shaopeng@jp.fujitsu.com>
> Reviewed-by: Tony Luck <tony.luck@intel.com>
> Reviewed-by: Reinette Chatre <reinette.chatre@intel.com>
> Reviewed-by: Fenghua Yu <fenghuay@nvidia.com>
> ---
> arch/x86/kernel/cpu/resctrl/rdtgroup.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/arch/x86/kernel/cpu/resctrl/rdtgroup.c
> b/arch/x86/kernel/cpu/resctrl/rdtgroup.c
> index aa0bc57e1c7f..d61b7137f443 100644
> --- a/arch/x86/kernel/cpu/resctrl/rdtgroup.c
> +++ b/arch/x86/kernel/cpu/resctrl/rdtgroup.c
> @@ -899,7 +899,6 @@ static int rdtgroup_rmid_show(struct kernfs_open_file
> *of, }
>
> #ifdef CONFIG_PROC_CPU_RESCTRL
> -
> /*
> * A task can only be part of one resctrl control group and of one monitor
> * group which is associated to that control group.
> --
> 2.20.1