linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Ilya Leoshkevich <iii@linux.ibm.com>
To: Steven Rostedt <rostedt@goodmis.org>,
	Masami Hiramatsu <mhiramat@kernel.org>
Cc: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>,
	Sven Schnelle <svens@linux.ibm.com>,
	linux-kernel@vger.kernel.org, linux-trace-kernel@vger.kernel.org,
	Heiko Carstens <hca@linux.ibm.com>,
	Vasily Gorbik <gor@linux.ibm.com>,
	Alexander Gordeev <agordeev@linux.ibm.com>,
	Ilya Leoshkevich <iii@linux.ibm.com>
Subject: [PATCH v2 0/2] ftrace: Expose call graph depth as unsigned int
Date: Sun, 13 Apr 2025 00:10:42 +0200	[thread overview]
Message-ID: <20250412221847.17310-1-iii@linux.ibm.com> (raw)

v1: https://lore.kernel.org/lkml/20250411172207.61332-1-iii@linux.ibm.com/
v1 -> v2: Use unsigned int instead of int.
          Add a follow-up patch that changes depth to unsigned int in
          all events.

Hi,

This series changes the type of depth in all call graph events to
unsigned int.

Patch 1 fixes a size mismatch issue in ftrace_graph_ent_entry, which
causes trace-cmd on 64-bit big-endian systems to output a lot of bogus
spaces, rendering it unusable.

Patch 2 changes type of depth in all other events to unsigned int in
order to better reflect its semantics: it can only be negative
internally, but recorded values are always non-negative.

Best regards,
Ilya

Ilya Leoshkevich (2):
  ftrace: Fix type of ftrace_graph_ent_entry.depth
  ftrace: Expose call graph depth as unsigned int

 kernel/trace/trace_entries.h | 16 ++++++++--------
 1 file changed, 8 insertions(+), 8 deletions(-)

-- 
2.49.0


             reply	other threads:[~2025-04-12 22:19 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-04-12 22:10 Ilya Leoshkevich [this message]
2025-04-12 22:10 ` [PATCH v2 1/2] ftrace: Fix type of ftrace_graph_ent_entry.depth Ilya Leoshkevich
2025-04-12 22:10 ` [PATCH v2 2/2] ftrace: Expose call graph depth as unsigned int Ilya Leoshkevich

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250412221847.17310-1-iii@linux.ibm.com \
    --to=iii@linux.ibm.com \
    --cc=agordeev@linux.ibm.com \
    --cc=gor@linux.ibm.com \
    --cc=hca@linux.ibm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-trace-kernel@vger.kernel.org \
    --cc=mathieu.desnoyers@efficios.com \
    --cc=mhiramat@kernel.org \
    --cc=rostedt@goodmis.org \
    --cc=svens@linux.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).