public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: alexjlzheng@gmail.com
Cc: tj@kernel.org, alexjlzheng@tencent.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH kernfs 1/3] kernfs: switch global kernfs_idr_lock to per-fs lock
Date: Sat, 12 Apr 2025 08:12:22 +0200	[thread overview]
Message-ID: <2025041256-sanction-sandal-7f51@gregkh> (raw)
In-Reply-To: <20250411183109.6334-2-alexjlzheng@tencent.com>

On Sat, Apr 12, 2025 at 02:31:07AM +0800, alexjlzheng@gmail.com wrote:
> From: Jinliang Zheng <alexjlzheng@tencent.com>
> 
> The kernfs implementation has big lock granularity(kernfs_idr_lock) so
> every kernfs-based(e.g., sysfs, cgroup) fs are able to compete the lock.
> 
> This patch switches the global kernfs_idr_lock to per-fs lock, which
> put the spinlock into kernfs_root.
> 
> Signed-off-by: Jinliang Zheng <alexjlzheng@tencent.com>
> ---
>  fs/kernfs/dir.c             | 14 +++++++-------
>  fs/kernfs/kernfs-internal.h |  1 +
>  2 files changed, 8 insertions(+), 7 deletions(-)

What kind of testing / benchmark did you do for this series that shows
that this works, AND that this actually is measureable?  What workload
are you doing that causes these changes to be needed?

thanks,

greg k-h

  reply	other threads:[~2025-04-12  6:12 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-04-11 18:31 [PATCH kernfs 0/3] kernfs: switch global locks to per-fs lock alexjlzheng
2025-04-11 18:31 ` [PATCH kernfs 1/3] kernfs: switch global kernfs_idr_lock " alexjlzheng
2025-04-12  6:12   ` Greg KH [this message]
2025-04-12 11:50     ` alexjlzheng
2025-04-13  7:51       ` Greg KH
2025-04-14  3:20         ` Jinliang Zheng
2025-04-15 15:16           ` Greg KH
2025-04-15 15:44             ` Jinliang Zheng
2025-04-14 17:09   ` Tejun Heo
2025-04-15  6:28     ` Jinliang Zheng
2025-04-11 18:31 ` [PATCH kernfs 2/3] kernfs: switch global kernfs_rename_lock " alexjlzheng
2025-04-14 17:26   ` Tejun Heo
2025-04-11 18:31 ` [PATCH kernfs 3/3] kernfs: switch global kernfs_pr_cont_lock " alexjlzheng
2025-04-14 17:27   ` Tejun Heo
2025-04-15  6:37     ` Jinliang Zheng

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2025041256-sanction-sandal-7f51@gregkh \
    --to=gregkh@linuxfoundation.org \
    --cc=alexjlzheng@gmail.com \
    --cc=alexjlzheng@tencent.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=tj@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox