From: Boqun Feng <boqun.feng@gmail.com>
To: Breno Leitao <leitao@debian.org>,
Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@redhat.com>, Will Deacon <will@kernel.org>,
Waiman Long <longman@redhat.com>
Cc: aeh@meta.com, linux-kernel@vger.kernel.org,
netdev@vger.kernel.org, edumazet@google.com, jhs@mojatatu.com,
kernel-team@meta.com, Erik Lundgren <elundgren@meta.com>,
"Paul E. McKenney" <paulmck@kernel.org>,
Frederic Weisbecker <frederic@kernel.org>,
Neeraj Upadhyay <neeraj.upadhyay@kernel.org>,
Joel Fernandes <joel@joelfernandes.org>,
Uladzislau Rezki <urezki@gmail.com>,
rcu@vger.kernel.org, Boqun Feng <boqun.feng@gmail.com>
Subject: [RFC PATCH 0/8] Introduce simple hazard pointers for lockdep
Date: Sun, 13 Apr 2025 23:00:47 -0700 [thread overview]
Message-ID: <20250414060055.341516-1-boqun.feng@gmail.com> (raw)
Hi,
This RFC is mostly a follow-up on discussion:
https://lore.kernel.org/lkml/20250321-lockdep-v1-1-78b732d195fb@debian.org/
I found that using a hazard pointer variant can speed up the
lockdep_unregister_key(), on my system (a 96-cpu VMs), the results of:
time /usr/sbin/tc qdisc replace dev eth0 root handle 0x1: mq
are
(without the patchset)
real 0m1.039s
user 0m0.001s
sys 0m0.069s
(with the patchset)
real 0m0.053s
user 0m0.000s
sys 0m0.051s
i.e. almost 20x speed-up.
Other comparisons between RCU and shazptr, the rcuscale results (using
default configuration from
tools/testing/selftests/rcutorture/bin/kvm.sh):
RCU:
Average grace-period duration: 7470.02 microseconds
Minimum grace-period duration: 3981.6
50th percentile grace-period duration: 6002.73
90th percentile grace-period duration: 7008.93
99th percentile grace-period duration: 10015
Maximum grace-period duration: 142228
shazptr:
Average grace-period duration: 0.845825 microseconds
Minimum grace-period duration: 0.199
50th percentile grace-period duration: 0.585
90th percentile grace-period duration: 1.656
99th percentile grace-period duration: 3.872
Maximum grace-period duration: 3049.05
shazptr (skip_synchronize_self_scan=1, i.e. always let scan kthread to
wakeup):
Average grace-period duration: 467.861 microseconds
Minimum grace-period duration: 92.913
50th percentile grace-period duration: 440.691
90th percentile grace-period duration: 460.623
99th percentile grace-period duration: 650.068
Maximum grace-period duration: 5775.46
shazptr_wildcard (i.e. readers always use SHAZPTR_WILDCARD):
Average grace-period duration: 599.569 microseconds
Minimum grace-period duration: 1.432
50th percentile grace-period duration: 582.631
90th percentile grace-period duration: 781.704
99th percentile grace-period duration: 1160.26
Maximum grace-period duration: 6727.53
shazptr_wildcard (skip_synchronize_self_scan=1):
Average grace-period duration: 460.466 microseconds
Minimum grace-period duration: 303.546
50th percentile grace-period duration: 424.334
90th percentile grace-period duration: 482.637
99th percentile grace-period duration: 600.214
Maximum grace-period duration: 4126.94
Overall it looks promising to me, but I would like to see how it
performs in the environment of Breno. Also as Paul always reminds me:
buggy code usually run faster, so please take a look in case I'm missing
something ;-) Thanks!
The patchset is based on v6.15-rc1.
Boqun Feng (8):
Introduce simple hazard pointers
shazptr: Add refscale test
shazptr: Add refscale test for wildcard
shazptr: Avoid synchronize_shaptr() busy waiting
shazptr: Allow skip self scan in synchronize_shaptr()
rcuscale: Allow rcu_scale_ops::get_gp_seq to be NULL
rcuscale: Add tests for simple hazard pointers
locking/lockdep: Use shazptr to protect the key hashlist
include/linux/shazptr.h | 73 +++++++++
kernel/locking/Makefile | 2 +-
kernel/locking/lockdep.c | 11 +-
kernel/locking/shazptr.c | 318 +++++++++++++++++++++++++++++++++++++++
kernel/rcu/rcuscale.c | 60 +++++++-
kernel/rcu/refscale.c | 77 ++++++++++
6 files changed, 534 insertions(+), 7 deletions(-)
create mode 100644 include/linux/shazptr.h
create mode 100644 kernel/locking/shazptr.c
--
2.47.1
next reply other threads:[~2025-04-14 6:01 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-14 6:00 Boqun Feng [this message]
2025-04-14 6:00 ` [RFC PATCH 1/8] Introduce simple hazard pointers Boqun Feng
2025-07-11 0:36 ` Paul E. McKenney
2025-04-14 6:00 ` [RFC PATCH 2/8] shazptr: Add refscale test Boqun Feng
2025-07-11 0:41 ` Paul E. McKenney
2025-04-14 6:00 ` [RFC PATCH 3/8] shazptr: Add refscale test for wildcard Boqun Feng
2025-07-11 0:42 ` Paul E. McKenney
2025-04-14 6:00 ` [RFC PATCH 4/8] shazptr: Avoid synchronize_shaptr() busy waiting Boqun Feng
2025-07-11 0:56 ` Paul E. McKenney
2025-07-11 2:29 ` Boqun Feng
2025-04-14 6:00 ` [RFC PATCH 5/8] shazptr: Allow skip self scan in synchronize_shaptr() Boqun Feng
2025-07-11 0:58 ` Paul E. McKenney
2025-04-14 6:00 ` [RFC PATCH 6/8] rcuscale: Allow rcu_scale_ops::get_gp_seq to be NULL Boqun Feng
2025-07-11 1:00 ` Paul E. McKenney
2025-04-14 6:00 ` [RFC PATCH 7/8] rcuscale: Add tests for simple hazard pointers Boqun Feng
2025-07-11 1:03 ` Paul E. McKenney
2025-04-14 6:00 ` [RFC PATCH 8/8] locking/lockdep: Use shazptr to protect the key hashlist Boqun Feng
2025-07-11 1:04 ` Paul E. McKenney
2025-04-16 14:14 ` [RFC PATCH 0/8] Introduce simple hazard pointers for lockdep Breno Leitao
2025-04-16 15:04 ` Uladzislau Rezki
2025-04-16 18:33 ` Breno Leitao
2025-04-17 8:22 ` Uladzislau Rezki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250414060055.341516-1-boqun.feng@gmail.com \
--to=boqun.feng@gmail.com \
--cc=aeh@meta.com \
--cc=edumazet@google.com \
--cc=elundgren@meta.com \
--cc=frederic@kernel.org \
--cc=jhs@mojatatu.com \
--cc=joel@joelfernandes.org \
--cc=kernel-team@meta.com \
--cc=leitao@debian.org \
--cc=linux-kernel@vger.kernel.org \
--cc=longman@redhat.com \
--cc=mingo@redhat.com \
--cc=neeraj.upadhyay@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=paulmck@kernel.org \
--cc=peterz@infradead.org \
--cc=rcu@vger.kernel.org \
--cc=urezki@gmail.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox