From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CB46725228B; Mon, 14 Apr 2025 13:26:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744637192; cv=none; b=MzPNNyud2o1qNAftRpHFzMGbHnM9r0kUmfYVt1SIDEqCjVuJX4A8xx4MkkjfZgFYSOwGDXd38V69SvHyUN7+ckn/Kce3/k98+3Hp6zJipnznacSmlokxdomUdcT4YzOA+EsxcuwiGMTIxFuEXFxyiIHYQiEVVhEQxMbMdOelEn4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744637192; c=relaxed/simple; bh=CJepgFajH+uEClC5+Nr4xS6NXi18SZs+QeUfB+qxRhs=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=UpL9ZC+hkx4VDGPfroVsfZJA4mgrjDCmUCLnKzRjIpRrcfBIBMtdcEDPLTpcgFZq+Gol5nmoX6QR5Ry/3KRkgAeGLwRETDXjpNkv4tZn+3QvdgwOiyPDGXIZ1cKyj4xOfvDCUfl7MKuJJiUfpyyHA8TZ3aYgo4m+E01BCsgshxc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=Dbr/INED; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="Dbr/INED" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 812BBC4CEE9; Mon, 14 Apr 2025 13:26:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1744637192; bh=CJepgFajH+uEClC5+Nr4xS6NXi18SZs+QeUfB+qxRhs=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Dbr/INEDDGfdA/i82DvLsznRYDPI65L2AGnSHDHvkqjZTNb7KHmRd1Vs8JVvImk54 C3OKQExiyAWYiZYLb1qeX/nZldvwXM5sf10WVwcEmEchGJwHhsftFmlfKii/aGl3yQ +8xBf6HcE2VyB0Qdueg50nWi9u5YM01pGBqxuIZ+O6DMywHJZG+uyEUXVdY64ro2gz hq0ZmKaJ8M+8cGZv+zFdTMGvtG5YOkvnXBCaMTjip8+gc4fWqaJ+bjTVGY7u7Ayi7c PmKVVM9Xfuj6fHgDLK+1ZGw4MOPlmsfhdPqWcbqRXcDUmdrQTA9fmILNFj37Q84rzI PcHXSETHdxAuw== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Hannes Reinecke , Keith Busch , Christoph Hellwig , Sasha Levin , sagi@grimberg.me, linux-nvme@lists.infradead.org Subject: [PATCH AUTOSEL 6.14 10/34] nvme: requeue namespace scan on missed AENs Date: Mon, 14 Apr 2025 09:25:46 -0400 Message-Id: <20250414132610.677644-10-sashal@kernel.org> X-Mailer: git-send-email 2.39.5 In-Reply-To: <20250414132610.677644-1-sashal@kernel.org> References: <20250414132610.677644-1-sashal@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore X-stable-base: Linux 6.14.2 Content-Transfer-Encoding: 8bit From: Hannes Reinecke [ Upstream commit 9546ad1a9bda7362492114f5866b95b0ac4a100e ] Scanning for namespaces can take some time, so if the target is reconfigured while the scan is running we may miss a Attached Namespace Attribute Changed AEN. Check if the NVME_AER_NOTICE_NS_CHANGED bit is set once the scan has finished, and requeue scanning to pick up any missed change. Signed-off-by: Hannes Reinecke Reviewed-by: Keith Busch Signed-off-by: Christoph Hellwig Signed-off-by: Sasha Levin --- drivers/nvme/host/core.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/drivers/nvme/host/core.c b/drivers/nvme/host/core.c index 8359d0aa0e44b..70f9c2d2b1130 100644 --- a/drivers/nvme/host/core.c +++ b/drivers/nvme/host/core.c @@ -4292,6 +4292,10 @@ static void nvme_scan_work(struct work_struct *work) nvme_scan_ns_sequential(ctrl); } mutex_unlock(&ctrl->scan_lock); + + /* Requeue if we have missed AENs */ + if (test_bit(NVME_AER_NOTICE_NS_CHANGED, &ctrl->events)) + nvme_queue_scan(ctrl); } /* -- 2.39.5