From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F311C291163; Mon, 14 Apr 2025 13:31:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744637470; cv=none; b=VVvq1S03ZpUeQQRfvZKuTtO3sMGeK6a4dNto7TKhQVMYjrZV8XhOEU09hnqXXSNvCLwtHdIOb7xYgd1nIuaW47GMvfBT1ZptsNOir9EUzwHU0/aFDUxnMztw1j4n0jFnh9i+dv+VSppHrarqC7f5B9Hwf8dYJAIDNLOEEZaTsp0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744637470; c=relaxed/simple; bh=Jt1TTZOEwctOuFMJvt8J8VyDkGcR6F2KZ+EnGDmCWcs=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=QwG1WoxYWxTBgE30rdTyvzgHSJcpqUcDSeaz3u070CBe9hv4+CjRMfO0I/ee96ui7pz7gbup1oq/ggCVtNxlZdWH/mHMOY13zeqCaJwV6vDw7eagCCLMT1BJ2S7yKigqoRavYgEhv6CmolAYsWFPH15ludD+8DiWOr8rIWFYVFE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=dKr7PKW7; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="dKr7PKW7" Received: by smtp.kernel.org (Postfix) with ESMTPSA id B01A7C4CEEB; Mon, 14 Apr 2025 13:31:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1744637469; bh=Jt1TTZOEwctOuFMJvt8J8VyDkGcR6F2KZ+EnGDmCWcs=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=dKr7PKW7I4F9rnxj9GbOy2csKN7vIZLiNb8XDfSM0C93AlTFj9bZTP86BfboS7MMY JI03WqmOAMn1LvQUFC31ZQFdgdq+r8cjPnhEatETiHiOw3VrnHbw//0j6bUqFzNiNi BPGSzC6AeDDyGPiyYL58vmViiJLAOa5WWY4k0n5/+S103k7igHNdUFGmrPZylUHKEH D0Ee8ViETLNf1Y25T4J19Pl/ZCGBn2Cj5/gFtxzXbFS8owM564jsojfDHy7h/ZyWbI aHWu2PIvvRYFYRXjJXCzKVci8I5rHpsaiF6g9KVeJM+NFvJJVV7PcKa3i9YSPuw/Lz TJxRF0Y2HjfgA== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Qiuxu Zhuo , Yi Lai , Shuah Khan , Sasha Levin , shuah@kernel.org, linux-kselftest@vger.kernel.org Subject: [PATCH AUTOSEL 6.1 10/17] selftests/mincore: Allow read-ahead pages to reach the end of the file Date: Mon, 14 Apr 2025 09:30:41 -0400 Message-Id: <20250414133048.680608-10-sashal@kernel.org> X-Mailer: git-send-email 2.39.5 In-Reply-To: <20250414133048.680608-1-sashal@kernel.org> References: <20250414133048.680608-1-sashal@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore X-stable-base: Linux 6.1.134 Content-Transfer-Encoding: 8bit From: Qiuxu Zhuo [ Upstream commit 197c1eaa7ba633a482ed7588eea6fd4aa57e08d4 ] When running the mincore_selftest on a system with an XFS file system, it failed the "check_file_mmap" test case due to the read-ahead pages reaching the end of the file. The failure log is as below: RUN global.check_file_mmap ... mincore_selftest.c:264:check_file_mmap:Expected i (1024) < vec_size (1024) mincore_selftest.c:265:check_file_mmap:Read-ahead pages reached the end of the file check_file_mmap: Test failed FAIL global.check_file_mmap This is because the read-ahead window size of the XFS file system on this machine is 4 MB, which is larger than the size from the #PF address to the end of the file. As a result, all the pages for this file are populated. blockdev --getra /dev/nvme0n1p5 8192 blockdev --getbsz /dev/nvme0n1p5 512 This issue can be fixed by extending the current FILE_SIZE 4MB to a larger number, but it will still fail if the read-ahead window size of the file system is larger enough. Additionally, in the real world, read-ahead pages reaching the end of the file can happen and is an expected behavior. Therefore, allowing read-ahead pages to reach the end of the file is a better choice for the "check_file_mmap" test case. Link: https://lore.kernel.org/r/20250311080940.21413-1-qiuxu.zhuo@intel.com Reported-by: Yi Lai Signed-off-by: Qiuxu Zhuo Signed-off-by: Shuah Khan Signed-off-by: Sasha Levin --- tools/testing/selftests/mincore/mincore_selftest.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/tools/testing/selftests/mincore/mincore_selftest.c b/tools/testing/selftests/mincore/mincore_selftest.c index 4c88238fc8f05..c0ae86c28d7f3 100644 --- a/tools/testing/selftests/mincore/mincore_selftest.c +++ b/tools/testing/selftests/mincore/mincore_selftest.c @@ -261,9 +261,6 @@ TEST(check_file_mmap) TH_LOG("No read-ahead pages found in memory"); } - EXPECT_LT(i, vec_size) { - TH_LOG("Read-ahead pages reached the end of the file"); - } /* * End of the readahead window. The rest of the pages shouldn't * be in memory. -- 2.39.5