From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.14]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C0E6E2586C7; Mon, 14 Apr 2025 08:09:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=192.198.163.14 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744618177; cv=none; b=t8d45btx2+HHrnzEP0OWM6Tmij2HFZViUNEIoZmWuKhsFl1lxls3T5Bj3v/qeuwGpp/kPGvpwP7+bJIjMg1N/lB+TVzUbEGTHDWXVVI06/AmEsbOYN/z1LKaO8E8tyBD1XUm47LGhs73rHquCSh3v4VNPJ28Uo7SSEynEX+C4/8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744618177; c=relaxed/simple; bh=h0j1Hfu+P4Ik7wn30u2UB2Z6uWgvo3dBsKVHdecR3uE=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=GihPtHjlUyClWijOd2qsCpqdFLs7uGK35up08sy2QRPq0hNSl9nUYGa8yMo8gw0El/uoOVMVDFZBEwGdHCEeS3G1J9TSwSZRVviRm9SFme1/fs/roN3319yfPUNz8uEcYer87U2J6HtBzPw2YRioNviiayDUlePWoRcuzYgQ5nc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com; spf=pass smtp.mailfrom=intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=nGk2Asg/; arc=none smtp.client-ip=192.198.163.14 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="nGk2Asg/" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1744618174; x=1776154174; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=h0j1Hfu+P4Ik7wn30u2UB2Z6uWgvo3dBsKVHdecR3uE=; b=nGk2Asg/XlFN1GEZg9NIPfKZ/POr27KDjT5Ijlf3CztjG+WMghXjzV25 OcZXlGkXusZ1+/s0E5tmEAi9KcjHx4jh4vwLvSmXXriLMAS6SXgxi1Szt 2cBSSnOSL2bTEMP7PTZYz3iF9zYnLkOgN4yf2/SvWVNJGFLfh40EAoITl LikWR4JzEENdCZZnT46MhWZqDcWaPGVn3Z5Y03f5gjyKUkWTuHE2yk92G V2gt0gXCmWrm04Wj1nKrGxtXzpIr4CVP7Ms7g/UzEPMzHivxXYtHkhjKu AuxaI0WfMPwjOJro/F0MYhJu+VRtGzq1rGfCf0wqN2aiJfgyBhUj1SDa2 w==; X-CSE-ConnectionGUID: zNQwS6mjTEGwzCKN5+o0Ww== X-CSE-MsgGUID: JLaQMe3JSs+FW4oZimKk5A== X-IronPort-AV: E=McAfee;i="6700,10204,11402"; a="46239540" X-IronPort-AV: E=Sophos;i="6.15,211,1739865600"; d="scan'208";a="46239540" Received: from orviesa010.jf.intel.com ([10.64.159.150]) by fmvoesa108.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 Apr 2025 01:09:33 -0700 X-CSE-ConnectionGUID: HS0x0csZR3WR491+o8WFfw== X-CSE-MsgGUID: 5AiuT9BLSwOJ7JRHOjoxdw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.15,211,1739865600"; d="scan'208";a="129691082" Received: from lkp-server01.sh.intel.com (HELO b207828170a5) ([10.239.97.150]) by orviesa010.jf.intel.com with ESMTP; 14 Apr 2025 01:09:30 -0700 Received: from kbuild by b207828170a5 with local (Exim 4.96) (envelope-from ) id 1u4Esh-000DvK-09; Mon, 14 Apr 2025 08:09:27 +0000 Date: Mon, 14 Apr 2025 16:08:37 +0800 From: kernel test robot To: Arnd Bergmann , Haibo Chen , Adrian Hunter , Ulf Hansson , Shawn Guo , Sascha Hauer , Luke Wang Cc: oe-kbuild-all@lists.linux.dev, Arnd Bergmann , Pengutronix Kernel Team , Fabio Estevam , Josua Mayer , imx@lists.linux.dev, linux-mmc@vger.kernel.org, s32@nxp.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] [v2] mmc: esdhc-imx: convert to modern PM_OPS Message-ID: <202504141551.hdiQj4os-lkp@intel.com> References: <20250411085932.1902662-1-arnd@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250411085932.1902662-1-arnd@kernel.org> Hi Arnd, kernel test robot noticed the following build errors: [auto build test ERROR on v6.15-rc2] [also build test ERROR on linus/master next-20250411] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch#_base_tree_information] url: https://github.com/intel-lab-lkp/linux/commits/Arnd-Bergmann/mmc-esdhc-imx-convert-to-modern-PM_OPS/20250414-092134 base: v6.15-rc2 patch link: https://lore.kernel.org/r/20250411085932.1902662-1-arnd%40kernel.org patch subject: [PATCH] [v2] mmc: esdhc-imx: convert to modern PM_OPS config: i386-buildonly-randconfig-006-20250414 (https://download.01.org/0day-ci/archive/20250414/202504141551.hdiQj4os-lkp@intel.com/config) compiler: gcc-12 (Debian 12.2.0-14) 12.2.0 reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250414/202504141551.hdiQj4os-lkp@intel.com/reproduce) If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot | Closes: https://lore.kernel.org/oe-kbuild-all/202504141551.hdiQj4os-lkp@intel.com/ All errors (new ones prefixed by >>): drivers/mmc/host/sdhci-esdhc-imx.c: In function 'sdhci_esdhc_suspend': >> drivers/mmc/host/sdhci-esdhc-imx.c:1902:15: error: implicit declaration of function 'sdhci_suspend_host'; did you mean 'sdhci_add_host'? [-Werror=implicit-function-declaration] 1902 | ret = sdhci_suspend_host(host); | ^~~~~~~~~~~~~~~~~~ | sdhci_add_host drivers/mmc/host/sdhci-esdhc-imx.c: In function 'sdhci_esdhc_resume': >> drivers/mmc/host/sdhci-esdhc-imx.c:1927:15: error: implicit declaration of function 'sdhci_resume_host'; did you mean 'sdhci_remove_host'? [-Werror=implicit-function-declaration] 1927 | ret = sdhci_resume_host(host); | ^~~~~~~~~~~~~~~~~ | sdhci_remove_host drivers/mmc/host/sdhci-esdhc-imx.c: In function 'sdhci_esdhc_runtime_suspend': >> drivers/mmc/host/sdhci-esdhc-imx.c:1953:15: error: implicit declaration of function 'sdhci_runtime_suspend_host' [-Werror=implicit-function-declaration] 1953 | ret = sdhci_runtime_suspend_host(host); | ^~~~~~~~~~~~~~~~~~~~~~~~~~ drivers/mmc/host/sdhci-esdhc-imx.c: In function 'sdhci_esdhc_runtime_resume': >> drivers/mmc/host/sdhci-esdhc-imx.c:1999:15: error: implicit declaration of function 'sdhci_runtime_resume_host' [-Werror=implicit-function-declaration] 1999 | err = sdhci_runtime_resume_host(host, 0); | ^~~~~~~~~~~~~~~~~~~~~~~~~ cc1: some warnings being treated as errors vim +1902 drivers/mmc/host/sdhci-esdhc-imx.c 95f25efe0ce22e Wolfram Sang 2010-10-15 1879 04143fbaeb5799 Dong Aisheng 2016-07-12 1880 static int sdhci_esdhc_suspend(struct device *dev) 04143fbaeb5799 Dong Aisheng 2016-07-12 1881 { 3e3274ab9ff37f Ulf Hansson 2016-07-27 1882 struct sdhci_host *host = dev_get_drvdata(dev); a26a4f1baca55a Haibo Chen 2020-02-19 1883 struct sdhci_pltfm_host *pltfm_host = sdhci_priv(host); a26a4f1baca55a Haibo Chen 2020-02-19 1884 struct pltfm_imx_data *imx_data = sdhci_pltfm_priv(pltfm_host); bb6e358169bf62 BOUGH CHEN 2019-01-07 1885 int ret; bb6e358169bf62 BOUGH CHEN 2019-01-07 1886 bb6e358169bf62 BOUGH CHEN 2019-01-07 1887 if (host->mmc->caps2 & MMC_CAP2_CQE) { bb6e358169bf62 BOUGH CHEN 2019-01-07 1888 ret = cqhci_suspend(host->mmc); bb6e358169bf62 BOUGH CHEN 2019-01-07 1889 if (ret) bb6e358169bf62 BOUGH CHEN 2019-01-07 1890 return ret; bb6e358169bf62 BOUGH CHEN 2019-01-07 1891 } 3e3274ab9ff37f Ulf Hansson 2016-07-27 1892 a26a4f1baca55a Haibo Chen 2020-02-19 1893 if ((imx_data->socdata->flags & ESDHC_FLAG_STATE_LOST_IN_LPMODE) && a26a4f1baca55a Haibo Chen 2020-02-19 1894 (host->tuning_mode != SDHCI_TUNING_MODE_1)) { a26a4f1baca55a Haibo Chen 2020-02-19 1895 mmc_retune_timer_stop(host->mmc); a26a4f1baca55a Haibo Chen 2020-02-19 1896 mmc_retune_needed(host->mmc); a26a4f1baca55a Haibo Chen 2020-02-19 1897 } a26a4f1baca55a Haibo Chen 2020-02-19 1898 d38dcad4e7b48f Adrian Hunter 2017-03-20 1899 if (host->tuning_mode != SDHCI_TUNING_MODE_3) d38dcad4e7b48f Adrian Hunter 2017-03-20 1900 mmc_retune_needed(host->mmc); d38dcad4e7b48f Adrian Hunter 2017-03-20 1901 af8fade4bd7bc7 Haibo Chen 2020-02-19 @1902 ret = sdhci_suspend_host(host); f6140462611308 Haibo Chen 2020-05-27 1903 if (ret) f6140462611308 Haibo Chen 2020-05-27 1904 return ret; f6140462611308 Haibo Chen 2020-05-27 1905 f6140462611308 Haibo Chen 2020-05-27 1906 ret = pinctrl_pm_select_sleep_state(dev); f6140462611308 Haibo Chen 2020-05-27 1907 if (ret) f6140462611308 Haibo Chen 2020-05-27 1908 return ret; f6140462611308 Haibo Chen 2020-05-27 1909 f6140462611308 Haibo Chen 2020-05-27 1910 ret = mmc_gpio_set_cd_wake(host->mmc, true); af8fade4bd7bc7 Haibo Chen 2020-02-19 1911 af8fade4bd7bc7 Haibo Chen 2020-02-19 1912 return ret; 04143fbaeb5799 Dong Aisheng 2016-07-12 1913 } 04143fbaeb5799 Dong Aisheng 2016-07-12 1914 04143fbaeb5799 Dong Aisheng 2016-07-12 1915 static int sdhci_esdhc_resume(struct device *dev) 04143fbaeb5799 Dong Aisheng 2016-07-12 1916 { cc17e1294b8aeb Dong Aisheng 2016-07-12 1917 struct sdhci_host *host = dev_get_drvdata(dev); bb6e358169bf62 BOUGH CHEN 2019-01-07 1918 int ret; cc17e1294b8aeb Dong Aisheng 2016-07-12 1919 af8fade4bd7bc7 Haibo Chen 2020-02-19 1920 ret = pinctrl_pm_select_default_state(dev); af8fade4bd7bc7 Haibo Chen 2020-02-19 1921 if (ret) af8fade4bd7bc7 Haibo Chen 2020-02-19 1922 return ret; af8fade4bd7bc7 Haibo Chen 2020-02-19 1923 19dbfdd3d5152d Dong Aisheng 2016-07-12 1924 /* re-initialize hw state in case it's lost in low power mode */ 19dbfdd3d5152d Dong Aisheng 2016-07-12 1925 sdhci_esdhc_imx_hwinit(host); cc17e1294b8aeb Dong Aisheng 2016-07-12 1926 bb6e358169bf62 BOUGH CHEN 2019-01-07 @1927 ret = sdhci_resume_host(host); bb6e358169bf62 BOUGH CHEN 2019-01-07 1928 if (ret) bb6e358169bf62 BOUGH CHEN 2019-01-07 1929 return ret; bb6e358169bf62 BOUGH CHEN 2019-01-07 1930 bb6e358169bf62 BOUGH CHEN 2019-01-07 1931 if (host->mmc->caps2 & MMC_CAP2_CQE) bb6e358169bf62 BOUGH CHEN 2019-01-07 1932 ret = cqhci_resume(host->mmc); bb6e358169bf62 BOUGH CHEN 2019-01-07 1933 f6140462611308 Haibo Chen 2020-05-27 1934 if (!ret) f6140462611308 Haibo Chen 2020-05-27 1935 ret = mmc_gpio_set_cd_wake(host->mmc, false); f6140462611308 Haibo Chen 2020-05-27 1936 bb6e358169bf62 BOUGH CHEN 2019-01-07 1937 return ret; 04143fbaeb5799 Dong Aisheng 2016-07-12 1938 } 04143fbaeb5799 Dong Aisheng 2016-07-12 1939 89d7e5c131228a Dong Aisheng 2013-11-04 1940 static int sdhci_esdhc_runtime_suspend(struct device *dev) 89d7e5c131228a Dong Aisheng 2013-11-04 1941 { 89d7e5c131228a Dong Aisheng 2013-11-04 1942 struct sdhci_host *host = dev_get_drvdata(dev); 89d7e5c131228a Dong Aisheng 2013-11-04 1943 struct sdhci_pltfm_host *pltfm_host = sdhci_priv(host); 070e6d3ff5a696 Jisheng Zhang 2016-02-16 1944 struct pltfm_imx_data *imx_data = sdhci_pltfm_priv(pltfm_host); 89d7e5c131228a Dong Aisheng 2013-11-04 1945 int ret; 89d7e5c131228a Dong Aisheng 2013-11-04 1946 bb6e358169bf62 BOUGH CHEN 2019-01-07 1947 if (host->mmc->caps2 & MMC_CAP2_CQE) { bb6e358169bf62 BOUGH CHEN 2019-01-07 1948 ret = cqhci_suspend(host->mmc); bb6e358169bf62 BOUGH CHEN 2019-01-07 1949 if (ret) bb6e358169bf62 BOUGH CHEN 2019-01-07 1950 return ret; bb6e358169bf62 BOUGH CHEN 2019-01-07 1951 } bb6e358169bf62 BOUGH CHEN 2019-01-07 1952 89d7e5c131228a Dong Aisheng 2013-11-04 @1953 ret = sdhci_runtime_suspend_host(host); 371d39fabcebc3 Michael Trimarchi 2018-01-04 1954 if (ret) 371d39fabcebc3 Michael Trimarchi 2018-01-04 1955 return ret; 89d7e5c131228a Dong Aisheng 2013-11-04 1956 d38dcad4e7b48f Adrian Hunter 2017-03-20 1957 if (host->tuning_mode != SDHCI_TUNING_MODE_3) d38dcad4e7b48f Adrian Hunter 2017-03-20 1958 mmc_retune_needed(host->mmc); d38dcad4e7b48f Adrian Hunter 2017-03-20 1959 3602785b341a95 Michael Trimarchi 2018-01-04 1960 imx_data->actual_clock = host->mmc->actual_clock; 3602785b341a95 Michael Trimarchi 2018-01-04 1961 esdhc_pltfm_set_clock(host, 0); 89d7e5c131228a Dong Aisheng 2013-11-04 1962 clk_disable_unprepare(imx_data->clk_per); 89d7e5c131228a Dong Aisheng 2013-11-04 1963 clk_disable_unprepare(imx_data->clk_ipg); 89d7e5c131228a Dong Aisheng 2013-11-04 1964 clk_disable_unprepare(imx_data->clk_ahb); 89d7e5c131228a Dong Aisheng 2013-11-04 1965 1c4989b000aeac BOUGH CHEN 2019-04-29 1966 if (imx_data->socdata->flags & ESDHC_FLAG_PMQOS) d1b98305916bc0 Rafael J. Wysocki 2020-02-12 1967 cpu_latency_qos_remove_request(&imx_data->pm_qos_req); 1c4989b000aeac BOUGH CHEN 2019-04-29 1968 89d7e5c131228a Dong Aisheng 2013-11-04 1969 return ret; 89d7e5c131228a Dong Aisheng 2013-11-04 1970 } 89d7e5c131228a Dong Aisheng 2013-11-04 1971 89d7e5c131228a Dong Aisheng 2013-11-04 1972 static int sdhci_esdhc_runtime_resume(struct device *dev) 89d7e5c131228a Dong Aisheng 2013-11-04 1973 { 89d7e5c131228a Dong Aisheng 2013-11-04 1974 struct sdhci_host *host = dev_get_drvdata(dev); 89d7e5c131228a Dong Aisheng 2013-11-04 1975 struct sdhci_pltfm_host *pltfm_host = sdhci_priv(host); 070e6d3ff5a696 Jisheng Zhang 2016-02-16 1976 struct pltfm_imx_data *imx_data = sdhci_pltfm_priv(pltfm_host); 17b1eb7f0bf3dc Fabio Estevam 2017-05-16 1977 int err; 89d7e5c131228a Dong Aisheng 2013-11-04 1978 1c4989b000aeac BOUGH CHEN 2019-04-29 1979 if (imx_data->socdata->flags & ESDHC_FLAG_PMQOS) d1b98305916bc0 Rafael J. Wysocki 2020-02-12 1980 cpu_latency_qos_add_request(&imx_data->pm_qos_req, 0); 1c4989b000aeac BOUGH CHEN 2019-04-29 1981 5c11f1ffb02244 Haibo Chen 2020-02-19 1982 if (imx_data->socdata->flags & ESDHC_FLAG_CLK_RATE_LOST_IN_PM_RUNTIME) 5c11f1ffb02244 Haibo Chen 2020-02-19 1983 clk_set_rate(imx_data->clk_per, pltfm_host->clock); 5c11f1ffb02244 Haibo Chen 2020-02-19 1984 a0ad3087586d09 Michael Trimarchi 2018-01-04 1985 err = clk_prepare_enable(imx_data->clk_ahb); a0ad3087586d09 Michael Trimarchi 2018-01-04 1986 if (err) 1c4989b000aeac BOUGH CHEN 2019-04-29 1987 goto remove_pm_qos_request; a0ad3087586d09 Michael Trimarchi 2018-01-04 1988 17b1eb7f0bf3dc Fabio Estevam 2017-05-16 1989 err = clk_prepare_enable(imx_data->clk_per); 17b1eb7f0bf3dc Fabio Estevam 2017-05-16 1990 if (err) a0ad3087586d09 Michael Trimarchi 2018-01-04 1991 goto disable_ahb_clk; af5d2b7b0d24f5 Ulf Hansson 2019-09-08 1992 17b1eb7f0bf3dc Fabio Estevam 2017-05-16 1993 err = clk_prepare_enable(imx_data->clk_ipg); 17b1eb7f0bf3dc Fabio Estevam 2017-05-16 1994 if (err) 17b1eb7f0bf3dc Fabio Estevam 2017-05-16 1995 goto disable_per_clk; af5d2b7b0d24f5 Ulf Hansson 2019-09-08 1996 3602785b341a95 Michael Trimarchi 2018-01-04 1997 esdhc_pltfm_set_clock(host, imx_data->actual_clock); a0ad3087586d09 Michael Trimarchi 2018-01-04 1998 c6303c5d52d5ec Baolin Wang 2019-07-25 @1999 err = sdhci_runtime_resume_host(host, 0); 17b1eb7f0bf3dc Fabio Estevam 2017-05-16 2000 if (err) a0ad3087586d09 Michael Trimarchi 2018-01-04 2001 goto disable_ipg_clk; 17b1eb7f0bf3dc Fabio Estevam 2017-05-16 2002 bb6e358169bf62 BOUGH CHEN 2019-01-07 2003 if (host->mmc->caps2 & MMC_CAP2_CQE) bb6e358169bf62 BOUGH CHEN 2019-01-07 2004 err = cqhci_resume(host->mmc); bb6e358169bf62 BOUGH CHEN 2019-01-07 2005 bb6e358169bf62 BOUGH CHEN 2019-01-07 2006 return err; 89d7e5c131228a Dong Aisheng 2013-11-04 2007 17b1eb7f0bf3dc Fabio Estevam 2017-05-16 2008 disable_ipg_clk: 17b1eb7f0bf3dc Fabio Estevam 2017-05-16 2009 clk_disable_unprepare(imx_data->clk_ipg); 17b1eb7f0bf3dc Fabio Estevam 2017-05-16 2010 disable_per_clk: 17b1eb7f0bf3dc Fabio Estevam 2017-05-16 2011 clk_disable_unprepare(imx_data->clk_per); a0ad3087586d09 Michael Trimarchi 2018-01-04 2012 disable_ahb_clk: a0ad3087586d09 Michael Trimarchi 2018-01-04 2013 clk_disable_unprepare(imx_data->clk_ahb); 1c4989b000aeac BOUGH CHEN 2019-04-29 2014 remove_pm_qos_request: 1c4989b000aeac BOUGH CHEN 2019-04-29 2015 if (imx_data->socdata->flags & ESDHC_FLAG_PMQOS) d1b98305916bc0 Rafael J. Wysocki 2020-02-12 2016 cpu_latency_qos_remove_request(&imx_data->pm_qos_req); 17b1eb7f0bf3dc Fabio Estevam 2017-05-16 2017 return err; 89d7e5c131228a Dong Aisheng 2013-11-04 2018 } 89d7e5c131228a Dong Aisheng 2013-11-04 2019 -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki