Re: [PATCH v1 4/7] gpiolib: Call validate_desc() when VALIDATE_DESC() can't be used

Linus Walleij
2025-04-16T08:44:31Z

On Tue, Apr 15, 2025 at 1:11 PM Andy Shevchenko
<andriy.shevchenko@linux.intel.com> wrote:

> Call validate_desc() directly when VALIDATE_DESC() can't be used.
> It will print additional information useful for debugging.
>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>

Reviewed-by: Linus Walleij <linus.walleij@linaro.org>

> offset = gpio_chip_hwgpio(desc);
> if (gc->to_irq) {
> - int retirq = gc->to_irq(gc, offset);
> + ret = gc->to_irq(gc, offset);
> + if (ret)
> + return ret;
>
> /* Zero means NO_IRQ */
> - if (!retirq)
> - return -ENXIO;
> -
> - return retirq;
> + return -ENXIO;

Totally unrelated change - but I'm fine with that :D

Yours,
Linus Walleij