Re: [PATCH v1 4/7] gpiolib: Call validate_desc() when VALIDATE_DESC() can't be used

Andy Shevchenko
2025-04-16T09:17:15Z

On Wed, Apr 16, 2025 at 10:44:18AM +0200, Linus Walleij wrote:
> On Tue, Apr 15, 2025 at 1:11 PM Andy Shevchenko
> <andriy.shevchenko@linux.intel.com> wrote:
>
> > Call validate_desc() directly when VALIDATE_DESC() can't be used.
> > It will print additional information useful for debugging.
> >
> > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
>
> Reviewed-by: Linus Walleij <linus.walleij@linaro.org>

Thank you!

...

> > if (gc->to_irq) {
> > - int retirq = gc->to_irq(gc, offset);
> > + ret = gc->to_irq(gc, offset);
> > + if (ret)
> > + return ret;
> >
> > /* Zero means NO_IRQ */
> > - if (!retirq)
> > - return -ENXIO;
> > -
> > - return retirq;
> > + return -ENXIO;
>
> Totally unrelated change - but I'm fine with that :D

It's not totally (it's a reuse of the same variable), but I can split it.
Bart, what do you prefer?

--
With Best Regards,
Andy Shevchenko