From: Lee Jones <lee@kernel.org>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Cc: Karel Balej <balejk@matfyz.cz>,
Chanwoo Choi <cw00.choi@samsung.com>,
Krzysztof Kozlowski <krzk@kernel.org>,
Orson Zhai <orsonzhai@gmail.com>,
Baolin Wang <baolin.wang@linux.alibaba.com>,
Chunyan Zhang <zhang.lyra@gmail.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 6/8] mfd: max8925: Fix wakeup source leaks on device unbind
Date: Tue, 15 Apr 2025 16:48:20 +0100 [thread overview]
Message-ID: <20250415154820.GX372032@google.com> (raw)
In-Reply-To: <20250406-mfd-device-wakekup-leak-v1-6-318e14bdba0a@linaro.org>
On Sun, 06 Apr 2025, Krzysztof Kozlowski wrote:
> Device can be unbound, so driver must also release memory for the wakeup
> source.
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> ---
> drivers/mfd/max8925-i2c.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/mfd/max8925-i2c.c b/drivers/mfd/max8925-i2c.c
> index 556aea7ec0a0473edc9291cae0c82fe9b4ecb346..ab19ff0c786732be53e58a0162d2658650d88f47 100644
> --- a/drivers/mfd/max8925-i2c.c
> +++ b/drivers/mfd/max8925-i2c.c
> @@ -201,6 +201,7 @@ static void max8925_remove(struct i2c_client *client)
> struct max8925_chip *chip = i2c_get_clientdata(client);
>
> max8925_device_exit(chip);
> + device_init_wakeup(&client->dev, false);
Why not devm_* instead?
> i2c_unregister_device(chip->adc);
> i2c_unregister_device(chip->rtc);
> }
>
> --
> 2.45.2
>
--
Lee Jones [李琼斯]
next prev parent reply other threads:[~2025-04-15 15:48 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-06 19:50 [PATCH 0/8] mfd: Fix wakeup source leaks on device unbind Krzysztof Kozlowski
2025-04-06 19:50 ` [PATCH 1/8] mfd: 88pm886: " Krzysztof Kozlowski
2025-04-08 13:45 ` Karel Balej
2025-04-06 19:50 ` [PATCH 2/8] mfd: as3722: " Krzysztof Kozlowski
2025-04-06 19:50 ` [PATCH 3/8] mfd: max14577: " Krzysztof Kozlowski
2025-04-15 15:49 ` Lee Jones
2025-04-06 19:50 ` [PATCH 4/8] mfd: max77541: " Krzysztof Kozlowski
2025-04-06 19:50 ` [PATCH 5/8] mfd: max77705: " Krzysztof Kozlowski
2025-04-06 19:50 ` [PATCH 6/8] mfd: max8925: " Krzysztof Kozlowski
2025-04-15 15:48 ` Lee Jones [this message]
2025-05-01 15:17 ` Krzysztof Kozlowski
2025-04-06 19:50 ` [PATCH 7/8] mfd: rt5033: " Krzysztof Kozlowski
2025-04-06 19:50 ` [PATCH 8/8] mfd: sprd-sc27xx: " Krzysztof Kozlowski
2025-04-07 1:56 ` Baolin Wang
2025-05-08 14:14 ` [PATCH 0/8] mfd: " Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250415154820.GX372032@google.com \
--to=lee@kernel.org \
--cc=balejk@matfyz.cz \
--cc=baolin.wang@linux.alibaba.com \
--cc=cw00.choi@samsung.com \
--cc=krzk@kernel.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=orsonzhai@gmail.com \
--cc=zhang.lyra@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox