From: Jakub Kicinski <kuba@kernel.org>
To: Qasim Ijaz <qasdev00@gmail.com>
Cc: andrew+netdev@lunn.ch, davem@davemloft.net, edumazet@google.com,
pabeni@redhat.com, horms@kernel.org, linux-usb@vger.kernel.org,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
syzbot+3361c2d6f78a3e0892f9@syzkaller.appspotmail.com,
stable@vger.kernel.org
Subject: Re: [PATCH 4/5] net: ch9200: add missing error handling in ch9200_bind()
Date: Tue, 15 Apr 2025 20:47:08 -0700 [thread overview]
Message-ID: <20250415204708.13dc3156@kernel.org> (raw)
In-Reply-To: <20250412183829.41342-5-qasdev00@gmail.com>
On Sat, 12 Apr 2025 19:38:28 +0100 Qasim Ijaz wrote:
> retval = usbnet_get_endpoints(dev, intf);
> - if (retval)
> + if (retval < 0)
> return retval;
This change is unnecessary ? Commit message speaks of control_write(),
this is usbnet_get_endpoints().
next prev parent reply other threads:[~2025-04-16 3:47 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-12 18:38 [PATCH 0/5] net: ch9200: fix various bugs and improve qinheng ch9200 driver Qasim Ijaz
2025-04-12 18:38 ` [PATCH 1/5] net: ch9200: fix uninitialised access bug during mii_nway_restart Qasim Ijaz
2025-04-15 1:28 ` Andrew Lunn
2025-04-12 18:38 ` [PATCH 2/5] net: ch9200: remove extraneous return that prevents error propagation Qasim Ijaz
2025-04-12 18:38 ` [PATCH 3/5] net: ch9200: fail fast on control_read() failures during get_mac_address() Qasim Ijaz
2025-04-12 18:38 ` [PATCH 4/5] net: ch9200: add missing error handling in ch9200_bind() Qasim Ijaz
2025-04-16 3:47 ` Jakub Kicinski [this message]
2025-04-17 13:07 ` Qasim Ijaz
2025-04-12 18:38 ` [PATCH 5/5] net: ch9200: avoid triggering NWay restart on non-zero PHY ID Qasim Ijaz
2025-04-15 1:35 ` Andrew Lunn
2025-04-16 3:52 ` Jakub Kicinski
2025-04-16 3:56 ` Jakub Kicinski
2025-04-17 13:12 ` Qasim Ijaz
2025-04-17 14:08 ` Andrew Lunn
2025-04-17 17:27 ` Qasim Ijaz
2025-04-25 10:13 ` Qasim Ijaz
2025-04-28 14:22 ` Andrew Lunn
2025-04-30 17:57 ` Qasim Ijaz
2025-05-09 15:21 ` Qasim Ijaz
2025-05-19 9:58 ` Qasim Ijaz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250415204708.13dc3156@kernel.org \
--to=kuba@kernel.org \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=qasdev00@gmail.com \
--cc=stable@vger.kernel.org \
--cc=syzbot+3361c2d6f78a3e0892f9@syzkaller.appspotmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).