Re: [PATCH v1 1/4] dt-bindings: display: panel: Document Renesas R61307 based DSI panel

[Rob Herring <robh@kernel.org>]

On Sun, Apr 13, 2025 at 02:23:58PM +0300, Svyatoslav Ryhel wrote:
> R61307 is liquid crystal driver for high-definition amorphous silicon
> (a-Si) panels and is ideal for tablets and smartphones.
> 
> Signed-off-by: Svyatoslav Ryhel <clamor95@gmail.com>
> ---
>  .../display/panel/renesas,r61307.yaml         | 93 +++++++++++++++++++
>  1 file changed, 93 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/display/panel/renesas,r61307.yaml
> 
> diff --git a/Documentation/devicetree/bindings/display/panel/renesas,r61307.yaml b/Documentation/devicetree/bindings/display/panel/renesas,r61307.yaml
> new file mode 100644
> index 000000000000..a98d2d2e02d2
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/display/panel/renesas,r61307.yaml
> @@ -0,0 +1,93 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/display/panel/renesas,r61307.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Renesas R61307 based DSI Display Panel
> +
> +maintainers:
> +  - Svyatoslav Ryhel <clamor95@gmail.com>
> +
> +description:
> +  The Renesas R61307 is a generic DSI Panel IC used to control LCD panels.
> +
> +allOf:
> +  - $ref: panel-common.yaml#
> +
> +properties:
> +  compatible:
> +    enum:
> +        # KOE/HITACHI TX13D100VM0EAA 5.0" XGA TFT LCD panel
> +      - hit,tx13d100vm0eaa
> +      - koe,tx13d100vm0eaa

Usuually when the display IC is known, there's a fallback compatible for 
it. Then 'renesas' vendor prefix on the properties makes more sense.

> +
> +  reg:
> +    maxItems: 1
> +
> +  vcc-supply:
> +    description: Regulator for main power supply.
> +
> +  iovcc-supply:
> +    description: Regulator for 1.8V IO power supply.
> +
> +  backlight: true
> +
> +  renesas,gamma:
> +    $ref: /schemas/types.yaml#/definitions/uint32
> +    description:
> +      0 - disabled
> +      1-3 - gamma setting A presets
> +    enum: [0, 1, 2, 3]
> +
> +  renesas,inversion:
> +    type: boolean
> +    description: switch between line and column inversion. The line
> +      inversion is set by default.

The property name is odd since there's always some sort of 
inversion. Perhaps renesas,column-inversion? 

> +
> +  renesas,contrast:
> +    type: boolean
> +    description: digital contrast adjustment

I would have expected contrast to be more than boolean. Is this 
something any a-Si panel would support or somehow Renesas specific?

> +
> +  reset-gpios: true
> +  port: true
> +
> +required:
> +  - compatible
> +  - port
> +  - backlight
> +
> +additionalProperties: false
> +
> +examples:
> +  - |
> +    #include <dt-bindings/gpio/gpio.h>
> +
> +    dsi {
> +        #address-cells = <1>;
> +        #size-cells = <0>;
> +
> +        panel@1 {
> +            compatible = "koe,tx13d100vm0eaa";
> +            reg = <1>;
> +
> +            reset-gpios = <&gpio 176 GPIO_ACTIVE_LOW>;
> +
> +            renesas,gamma = <3>;
> +            renesas,inversion;
> +            renesas,contrast;
> +
> +            vcc-supply = <&vcc_3v0_lcd>;
> +            iovcc-supply = <&iovcc_1v8_lcd>;
> +
> +            backlight = <&backlight>;
> +
> +            port {
> +                panel_in: endpoint {
> +                    remote-endpoint = <&dsi_out>;
> +                };
> +            };
> +        };
> +    };
> +
> +...
> -- 
> 2.43.0
>