Re: [PATCH] arm64: dts: Fix nuvoton 8xx clock properties

Krzysztof Kozlowski
2025-04-16T06:55:17Z

On 16/04/2025 01:25, William A. Kennington III wrote:
> The latest iteration of the clock driver got rid of the separate clock

I don't see the binding deprecated.

> compatible node, merging clock and reset devices.
>
> Signed-off-by: William A. Kennington III <william@wkennington.com>
> ---
> .../boot/dts/nuvoton/nuvoton-common-npcm8xx.dtsi | 16 ++++++----------
> .../boot/dts/nuvoton/nuvoton-npcm845-evb.dts | 8 ++++++++
> 2 files changed, 14 insertions(+), 10 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/nuvoton/nuvoton-common-npcm8xx.dtsi b/arch/arm64/boot/dts/nuvoton/nuvoton-common-npcm8xx.dtsi
> index ecd171b2feba..4da62308b274 100644
> --- a/arch/arm64/boot/dts/nuvoton/nuvoton-common-npcm8xx.dtsi
> +++ b/arch/arm64/boot/dts/nuvoton/nuvoton-common-npcm8xx.dtsi
> @@ -47,17 +47,13 @@ ahb {
> interrupt-parent = <&gic>;
> ranges;
>
> - rstc: reset-controller@f0801000 {
> + clk: rstc: reset-controller@f0801000 {
> compatible = "nuvoton,npcm845-reset";
> reg = <0x0 0xf0801000 0x0 0x78>;

So now it lacks quite a bit of address space. This must be explained in
commit msg.

> #reset-cells = <2>;
> nuvoton,sysgcr = <&gcr>;
> - };
> -
> - clk: clock-controller@f0801000 {
> - compatible = "nuvoton,npcm845-clk";
> + clocks = <&refclk>;
> #clock-cells = <1>;
> - reg = <0x0 0xf0801000 0x0 0x1000>;
> };
>
> apb {
> @@ -81,7 +77,7 @@ timer0: timer@8000 {
> compatible = "nuvoton,npcm845-timer";
> interrupts = <GIC_SPI 32 IRQ_TYPE_LEVEL_HIGH>;
> reg = <0x8000 0x1C>;
> - clocks = <&clk NPCM8XX_CLK_REFCLK>;
> + clocks = <&refclk>;

Not explained in commit msg.

Best regards,
Krzysztof