Re: [PATCH] arm64: dts: nuvoton: Add EDAC controller

Krzysztof Kozlowski
2025-04-16T06:53:03Z

On 16/04/2025 02:13, William A. Kennington III wrote:
> We have the driver support but need a common node for all the 8xx
> platforms that contain this device.
>
> Signed-off-by: William A. Kennington III <william@wkennington.com>
> ---

You just sent it, so this is v2? If so, then use v2 in subject (see
other patches) and provide changelog under ---.

> arch/arm64/boot/dts/nuvoton/nuvoton-common-npcm8xx.dtsi | 7 +++++++
> 1 file changed, 7 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/nuvoton/nuvoton-common-npcm8xx.dtsi b/arch/arm64/boot/dts/nuvoton/nuvoton-common-npcm8xx.dtsi
> index 4da62308b274..ccebcb11c05e 100644
> --- a/arch/arm64/boot/dts/nuvoton/nuvoton-common-npcm8xx.dtsi
> +++ b/arch/arm64/boot/dts/nuvoton/nuvoton-common-npcm8xx.dtsi
> @@ -56,6 +56,13 @@ clk: rstc: reset-controller@f0801000 {
> #clock-cells = <1>;
> };
>
> + mc: memory-controller@f0824000 {
> + compatible = "nuvoton,npcm845-memory-controller";
> + reg = <0x0 0xf0824000 0x0 0x2000>;
> + interrupts = <GIC_SPI 25 IRQ_TYPE_LEVEL_HIGH>;
> + status = "disabled";

Why is this disabled? What resources are missing?

Best regards,
Krzysztof