public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Kuniyuki Iwashima <kuniyu@amazon.com>
To: <jlayton@kernel.org>
Cc: <akpm@linux-foundation.org>, <andrew@lunn.ch>,
	<davem@davemloft.net>, <edumazet@google.com>, <horms@kernel.org>,
	<kuba@kernel.org>, <kuniyu@amazon.com>,
	<linux-kernel@vger.kernel.org>, <nathan@kernel.org>,
	<netdev@vger.kernel.org>, <pabeni@redhat.com>,
	<qasdev00@gmail.com>
Subject: Re: [PATCH v2 6/8] net: add ref_tracker_dir_debugfs() calls for netns refcount tracking
Date: Tue, 15 Apr 2025 18:52:52 -0700	[thread overview]
Message-ID: <20250416015257.36336-1-kuniyu@amazon.com> (raw)
In-Reply-To: <20250415-reftrack-dbgfs-v2-6-b18c4abd122f@kernel.org>

From: Jeff Layton <jlayton@kernel.org>
Date: Tue, 15 Apr 2025 14:49:44 -0400
> After assigning the inode number to the namespace, use it to create a
> unique name for each netns refcount tracker and register the debugfs
> files for them.
> 
> The init_net is registered early in the boot process before the
> ref_tracker dir is created, so add a late_initcall() to register its
> files.
> 
> Signed-off-by: Jeff Layton <jlayton@kernel.org>
> ---
>  net/core/net_namespace.c | 34 +++++++++++++++++++++++++++++++++-
>  1 file changed, 33 insertions(+), 1 deletion(-)
> 
> diff --git a/net/core/net_namespace.c b/net/core/net_namespace.c
> index 4303f2a4926243e2c0ff0c0387383cd8e0658019..f636eb9b8eba28114fd192d64bcd359a25381988 100644
> --- a/net/core/net_namespace.c
> +++ b/net/core/net_namespace.c
> @@ -761,12 +761,44 @@ struct net *get_net_ns_by_pid(pid_t pid)
>  }
>  EXPORT_SYMBOL_GPL(get_net_ns_by_pid);
>  
> +#ifdef CONFIG_NET_NS_REFCNT_TRACKER
> +static void net_ns_net_debugfs(struct net *net)
> +{
> +	char name[32];

Perhaps define REF_TRACKER_NAMESZ (I'm really bad at naming) and reuse
it in the next two patches ?

Otherwise looks good to me.

Reviewed-by: Kuniyuki Iwashima <kuniyu@amazon.com>

  reply	other threads:[~2025-04-16  1:53 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-04-15 18:49 [PATCH v2 0/8] ref_tracker: add ability to register a debugfs file for a ref_tracker_dir Jeff Layton
2025-04-15 18:49 ` [PATCH v2 1/8] ref_tracker: don't use %pK in pr_ostream() output Jeff Layton
2025-04-15 18:49 ` [PATCH v2 2/8] ref_tracker: add a top level debugfs directory for ref_tracker Jeff Layton
2025-04-15 18:49 ` [PATCH v2 3/8] ref_tracker: have callers pass output function to pr_ostream() Jeff Layton
2025-04-15 18:49 ` [PATCH v2 4/8] ref_tracker: allow pr_ostream() to print directly to a seq_file Jeff Layton
2025-04-15 18:49 ` [PATCH v2 5/8] ref_tracker: add ability to register a file in debugfs for a ref_tracker_dir Jeff Layton
2025-04-15 18:49 ` [PATCH v2 6/8] net: add ref_tracker_dir_debugfs() calls for netns refcount tracking Jeff Layton
2025-04-16  1:52   ` Kuniyuki Iwashima [this message]
2025-04-15 18:49 ` [PATCH v2 7/8] ref_tracker: widen the ref_tracker_dir.name field Jeff Layton
2025-04-15 18:49 ` [PATCH v2 8/8] net: register debugfs file for net_device refcnt tracker Jeff Layton
2025-04-16  2:00   ` Kuniyuki Iwashima

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250416015257.36336-1-kuniyu@amazon.com \
    --to=kuniyu@amazon.com \
    --cc=akpm@linux-foundation.org \
    --cc=andrew@lunn.ch \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=horms@kernel.org \
    --cc=jlayton@kernel.org \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=nathan@kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=qasdev00@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox