Re: [PATCH v3 4/8] dt-bindings: phy: mtk-xs-phy: support type switch by pericfg

Frank Wunderlich (linux)
2025-04-17T09:35:03Z

Am 2025-04-17 09:59, schrieb Krzysztof Kozlowski:
> On 17/04/2025 09:52, Frank Wunderlich (linux) wrote:
>>>>
>>>> + mediatek,syscon-type:
>>>> + $ref: /schemas/types.yaml#/definitions/phandle-array
>>>> + maxItems: 1
>>>> + description:
>>>> + A phandle to syscon used to access the register of type
>>>> switch,
>>>> + the field should always be 3 cells long.
>>>> + items:
>>>> + items:
>>>
>>> Missing -, because you have one phandle.
>>
>> ok, then i need to drop MaxItems and indent 2 spaces more, but no
>> problem
>
> I missed that maxItems - should not be placed above description, but
> immediately around items.

dt_binding_check complains about maxItems should not be set when having
only 1 item ;)
so i dropped it in my current version completely.

>>
>>>> + - description:
>>>> + The first cell represents a phandle to syscon
>>>
>>> Don't repeat constraints in free form text. "Foo bar system
>>> controller"
>>> or "Phandle to foo bar system controller"
>>
>> i would write only "phandle to system controller". on mt7988 it is the
>> topmisc syscon, but maybe on
>> other SoC it is different name.
>
> This must be specific to what sort of system controller you point. You
> are not interested in phandle to any system controller.

how about phy configuration controller/register?

>>
>>>> + - description:
>>>> + The second cell represents the register offset
>>>
>>> "Baz register offset"
>>
>> same here, only "register offset".
>
> Also not. You need specific register, not any register.
>
>
> Best regards,
> Krzysztof