From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Thomas Gleixner <tglx@linutronix.de>, linux-kernel@vger.kernel.org
Cc: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Subject: [PATCH v1 2/2] genirq/irqdesc: Balance locking to make sparse happy
Date: Wed, 16 Apr 2025 14:40:34 +0300 [thread overview]
Message-ID: <20250416114122.2191820-3-andriy.shevchenko@linux.intel.com> (raw)
In-Reply-To: <20250416114122.2191820-1-andriy.shevchenko@linux.intel.com>
Sparse is not happy right now about conditional locking and
complains:
irqdesc.c:899:17: warning: context imbalance in '__irq_get_desc_lock' - wrong count at exit
Refactor the code and use __acquire() to make it happy.
Annotate the function that it acquires the lock in the
similar way how __irq_put_desc_unlock() is marked.
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
kernel/irq/irqdesc.c | 11 ++++++++---
1 file changed, 8 insertions(+), 3 deletions(-)
diff --git a/kernel/irq/irqdesc.c b/kernel/irq/irqdesc.c
index 0afc2b0b03be..cecff0cb13eb 100644
--- a/kernel/irq/irqdesc.c
+++ b/kernel/irq/irqdesc.c
@@ -899,21 +899,22 @@ unsigned int irq_get_next_irq(unsigned int offset)
struct irq_desc *
__irq_get_desc_lock(unsigned int irq, unsigned long *flags, bool bus,
unsigned int check)
+ __acquires(&desc->lock)
{
struct irq_desc *desc;
desc = irq_to_desc(irq);
if (!desc)
- return NULL;
+ goto lock;
if (check & _IRQ_DESC_CHECK) {
if ((check & _IRQ_DESC_PERCPU) &&
!irq_settings_is_per_cpu_devid(desc))
- return NULL;
+ goto lock;
if (!(check & _IRQ_DESC_PERCPU) &&
irq_settings_is_per_cpu_devid(desc))
- return NULL;
+ goto lock;
}
if (bus)
@@ -921,6 +922,10 @@ __irq_get_desc_lock(unsigned int irq, unsigned long *flags, bool bus,
raw_spin_lock_irqsave(&desc->lock, *flags);
return desc;
+
+lock:
+ __acquire(&desc->lock);
+ return NULL;
}
void __irq_put_desc_unlock(struct irq_desc *desc, unsigned long flags, bool bus)
--
2.47.2
next prev parent reply other threads:[~2025-04-16 11:41 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-16 11:40 [PATCH v1 0/2] genirq/irqdesc: Make sparse happy Andy Shevchenko
2025-04-16 11:40 ` [PATCH v1 1/2] genirq/irqdesc: Decrease indentation level in __irq_get_desc_lock() Andy Shevchenko
2025-05-05 13:36 ` [tip: irq/core] " tip-bot2 for Andy Shevchenko
2025-04-16 11:40 ` Andy Shevchenko [this message]
2025-04-16 11:52 ` [PATCH v1 2/2] genirq/irqdesc: Balance locking to make sparse happy Andy Shevchenko
2025-04-16 11:53 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250416114122.2191820-3-andriy.shevchenko@linux.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox