[PATCH v2 18/18] staging: gpib: Removing typedef gpib_interface_t

Michael Rubin
2025-04-16T20:42:29Z

Removing gpib_interface_t to adhere to Linux code style.

Reported by checkpatch.pl

In general, a pointer, or a struct that has elements that can reasonably be
directly accessed should never be a typedef.

Signed-off-by: Michael Rubin <matchstick@neverthere.org>
---
drivers/staging/gpib/include/gpib_types.h | 7 +++----
1 file changed, 3 insertions(+), 4 deletions(-)

diff --git a/drivers/staging/gpib/include/gpib_types.h b/drivers/staging/gpib/include/gpib_types.h
index 16aaade310fd..62ce174add85 100644
--- a/drivers/staging/gpib/include/gpib_types.h
+++ b/drivers/staging/gpib/include/gpib_types.h
@@ -8,7 +8,7 @@
#define _GPIB_TYPES_H

#ifdef __KERNEL__
-/* gpib_interface_t defines the interface
+/* gpib_interface defines the interface
* between the board-specific details dealt with in the drivers
* and generic interface provided by gpib-common.
* This really should be in a different header file.
@@ -22,7 +22,6 @@
#include <linux/timer.h>
#include <linux/interrupt.h>

-typedef struct gpib_interface gpib_interface_t;
struct gpib_board;

/* config parameters that are only used by driver attach functions */
@@ -212,7 +211,7 @@ static inline void init_gpib_pseudo_irq(struct gpib_pseudo_irq *pseudo_irq)
/* list so we can make a linked list of drivers */
struct gpib_interface_list {
struct list_head list;
- gpib_interface_t *interface;
+ struct gpib_interface *interface;
struct module *module;
};

@@ -222,7 +221,7 @@ struct gpib_interface_list {
*/
struct gpib_board {
/* functions used by this board */
- gpib_interface_t *interface;
+ struct gpib_interface *interface;
/* Pointer to module whose use count we should increment when
* interface is in use
*/
--
2.43.0