From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from bali.collaboradmins.com (bali.collaboradmins.com [148.251.105.195]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 74DE324C088 for ; Thu, 17 Apr 2025 12:26:59 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=148.251.105.195 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744892821; cv=none; b=uvcXmCjw53JnBIragqN2i/XW3Kkdh6MTmIZPD39vLB1zT6HSMM7QImpp895vXs7VM0QnzVWlY1vz/EZzm5iyMUDp5y/vKtyyzc8s6AqudF7T/li/3eJVZtOMSNbDTk44DIbSHB0+d6Gwd9/LD3tgIhywKASQAr1cZeE/eh+3w9I= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744892821; c=relaxed/simple; bh=ojopRztzKPVRCLLKy8aV8hgS574nLCWJ9ltF38ifVnE=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=fqb+Mhzz/ke0TQF5f6bQD0FZ45Wnl4V/2HBCRBZCjl/IE6Q3QYTMYPXxHDbEfiQ3Y2m1ojwFI1FK+8G1jDeKV5kO3pOYiJP1y+8A+DHOrJxj+sh5VI45j8Rlv5ZWWv8G2KYvsqlARC2pAxfPvk0o+MH01KncG8tfI+6GrcrN/0Y= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com; spf=pass smtp.mailfrom=collabora.com; dkim=pass (2048-bit key) header.d=collabora.com header.i=@collabora.com header.b=Krgqvkxt; arc=none smtp.client-ip=148.251.105.195 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=collabora.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=collabora.com header.i=@collabora.com header.b="Krgqvkxt" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1744892812; bh=ojopRztzKPVRCLLKy8aV8hgS574nLCWJ9ltF38ifVnE=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=Krgqvkxt5D06ccgRe31XlRADcAHPrGxn2CBjFE+0N5YtTi0fLkEdSaU6xXILXudH4 Ot0/xVy3Irz95IQ6FQ+UeriOAuyVCjxRgCw29fbakHWFu6ZHpLkUDZHYpJaAdRoOQ3 OkFkHCRznQiJJnC2MH5KYznR6Lx6n+iukJtmC5FHJEih/tCrndkLU4rT0QnlHqsEig WTICPf3PG3wq3wC2JtcVBIooN40T07TQmTDLbxL7W20XeNM6wccQo6JkOjbOGoaCNK k0PjY0/T7rsWa+oDxNSLCWWb3dfJzDqz+itEElKYQRh67ymdnH8MVTo00riBzhDPiy 93iYm1zfqTpcw== Received: from localhost (unknown [IPv6:2a01:e0a:2c:6930:5cf4:84a1:2763:fe0d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: bbrezillon) by bali.collaboradmins.com (Postfix) with ESMTPSA id E19E217E0F66; Thu, 17 Apr 2025 14:26:51 +0200 (CEST) Date: Thu, 17 Apr 2025 14:26:47 +0200 From: Boris Brezillon To: =?UTF-8?B?QWRyacOhbg==?= Larumbe Cc: Steven Price , Liviu Dudau , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , kernel@collabora.com, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v8 2/4] drm/panthor: Add driver IOCTL for setting BO labels Message-ID: <20250417142647.5d287244@collabora.com> In-Reply-To: <20250415191539.55258-2-adrian.larumbe@collabora.com> References: <20250415191539.55258-1-adrian.larumbe@collabora.com> <20250415191539.55258-2-adrian.larumbe@collabora.com> Organization: Collabora X-Mailer: Claws Mail 4.3.0 (GTK 3.24.43; x86_64-redhat-linux-gnu) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On Tue, 15 Apr 2025 20:15:31 +0100 Adri=C3=A1n Larumbe wrote: > +/** > + * struct drm_panthor_bo_set_label - Arguments passed to DRM_IOCTL_PANTH= OR_BO_SET_LABEL > + */ > +struct drm_panthor_bo_set_label { > + /** @handle: Handle of the buffer object to label. */ > + __u32 handle; > + Funny that this one pops up just after I fixed a missing-padding-field issue in panthor_drm.h. We really need to tool based on pahole to detect those before merging. TLDR; /** @pad: MBZ. */ __u32 pad; > + /** > + * @label: User pointer to a NUL-terminated string > + * > + * Length cannot be greater than 4096 > + */ > + __u64 label; > +}; > + > /** > * DRM_IOCTL_PANTHOR() - Build a Panthor IOCTL number > * @__access: Access type. Must be R, W or RW. > @@ -1019,6 +1037,8 @@ enum { > DRM_IOCTL_PANTHOR(WR, TILER_HEAP_CREATE, tiler_heap_create), > DRM_IOCTL_PANTHOR_TILER_HEAP_DESTROY =3D > DRM_IOCTL_PANTHOR(WR, TILER_HEAP_DESTROY, tiler_heap_destroy), > + DRM_IOCTL_PANTHOR_BO_SET_LABEL =3D > + DRM_IOCTL_PANTHOR(WR, BO_SET_LABEL, bo_set_label), > }; > =20 > #if defined(__cplusplus)