From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from frasgout.his.huawei.com (frasgout.his.huawei.com [185.176.79.56]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 538C6253928; Thu, 17 Apr 2025 17:36:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.176.79.56 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744911387; cv=none; b=i2/3PmLHlNUyXYIDVUAEexhlmsavnuM1Y/bbjKSV+t20M+u1o47rl7rF8/xNZIYzShtQ1kMzf0e3+gAm/RoDJ0tMhzmKgvEwOzwX1jAr9fGymIs/DPsyxbTZjjd2ccwxQQb7RiVPNPCHiGsKB+NSTDMjanG8EPRr7bVXs/aRck8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744911387; c=relaxed/simple; bh=D+aD4gDSSv44m0ExpyQjQrZDccBz+XDcDmTosHrSBds=; h=Date:From:To:CC:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=ANGbXZoBOMyvz4PatQEgmR0aKkRAW3dRxiXIY1tR5JOEcanBcHhd4N0AqwBi8Lrymf2yefjCaaKJBG89r5i+j/2Oh6UnvlW9e82afSrrSfr62Bvrabk7UlTXJG3FuI3UI3Z0cXzKjN6MU+HqdCwle6RxNG5egZDqM0FoknNZQ+8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=huawei.com; spf=pass smtp.mailfrom=huawei.com; arc=none smtp.client-ip=185.176.79.56 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=huawei.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=huawei.com Received: from mail.maildlp.com (unknown [172.18.186.231]) by frasgout.his.huawei.com (SkyGuard) with ESMTP id 4ZdlMV4Whrz6M4hX; Fri, 18 Apr 2025 01:32:22 +0800 (CST) Received: from frapeml500008.china.huawei.com (unknown [7.182.85.71]) by mail.maildlp.com (Postfix) with ESMTPS id 65952140145; Fri, 18 Apr 2025 01:36:23 +0800 (CST) Received: from localhost (10.203.177.66) by frapeml500008.china.huawei.com (7.182.85.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.39; Thu, 17 Apr 2025 19:36:22 +0200 Date: Thu, 17 Apr 2025 18:36:21 +0100 From: Jonathan Cameron To: David Lechner CC: Jonathan Cameron , Nuno =?ISO-8859-1?Q?S=E1?= , Andy Shevchenko , Matthias Brugger , AngeloGioacchino Del Regno , Lars-Peter Clausen , Michael Hennerich , "Cosmin Tanislav" , Tomasz Duszynski , Jean-Baptiste Maneyrol , Andreas Klinger , "Petre Rodan" , , , , Subject: Re: [PATCH 5/8] iio: chemical: sps30: use aligned_s64 for timestamp Message-ID: <20250417183621.00001c67@huawei.com> In-Reply-To: <20250417-iio-more-timestamp-alignment-v1-5-eafac1e22318@baylibre.com> References: <20250417-iio-more-timestamp-alignment-v1-0-eafac1e22318@baylibre.com> <20250417-iio-more-timestamp-alignment-v1-5-eafac1e22318@baylibre.com> X-Mailer: Claws Mail 4.3.0 (GTK 3.24.42; x86_64-w64-mingw32) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit X-ClientProxiedBy: lhrpeml500011.china.huawei.com (7.191.174.215) To frapeml500008.china.huawei.com (7.182.85.71) On Thu, 17 Apr 2025 11:52:37 -0500 David Lechner wrote: > Follow the pattern of other drivers and use aligned_s64 for the > timestamp. This will ensure that the timestamp is correctly aligned on > all architectures. > > Signed-off-by: David Lechner > --- > drivers/iio/chemical/sps30.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/iio/chemical/sps30.c b/drivers/iio/chemical/sps30.c > index 6f4f2ba2c09d5e691df13bc11ca9e3a910d98dc8..a7888146188d09ddbf376b398ee24dab7f0e2611 100644 > --- a/drivers/iio/chemical/sps30.c > +++ b/drivers/iio/chemical/sps30.c > @@ -108,7 +108,7 @@ static irqreturn_t sps30_trigger_handler(int irq, void *p) > int ret; > struct { > s32 data[4]; /* PM1, PM2P5, PM4, PM10 */ > - s64 ts; > + aligned_s64 ts; Definitely a bug as we have no idea what is next on the stack so fixes tag needed. > } scan; > > mutex_lock(&state->lock); >