From: Kurt Borja <kuurtb@gmail.com>
To: Miri Korenblit <miriam.rachel.korenblit@intel.com>,
Johannes Berg <johannes.berg@intel.com>,
Emmanuel Grumbach <emmanuel.grumbach@intel.com>
Cc: linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org,
Kurt Borja <kuurtb@gmail.com>
Subject: [PATCH v2] wifi: iwlwifi: pcie: Fix match condition in iwl_pci_find_dev_info()
Date: Fri, 18 Apr 2025 03:29:37 -0300 [thread overview]
Message-ID: <20250418-probe-fix-v2-1-ec1ef2d8a534@gmail.com> (raw)
Fix the following regression:
iwlwifi: No config found for PCI dev 2725/1674, rev=0x420, rfid=0x10d000
iwlwifi 0000:3b:00.0: probe with driver iwlwifi failed with error -22
Which happens due to an extra `!` when matching `dev_info` while
probing.
Fixes: 75a3313f52b7 ("wifi: iwlwifi: make no_160 more generic")
Signed-off-by: Kurt Borja <kuurtb@gmail.com>
---
Hi all,
After testing Linux v6.15-rc1 I found that my wifi card was failing to
probe. This is a major regression which leaves me without wifi and is
still present in Linux v6.15-rc2.
Bisecting led to:
first bad commit: [75a3313f52b7] wifi: iwlwifi: make no_160 more generic
in which I found this this `!` typo.
I already sent a fix for this (v1), but it probably ended up in spam due
to a bad DKIM signature.
This patch is based on the for-next branch of the wireless/wireless.git
tree.
---
Changes since v1:
- Heavily reword commit message to be more clear
- Link: https://lore.kernel.org/r/20250329-wifi-fix-v1-1-d6360e78f091@gmail.com/
---
drivers/net/wireless/intel/iwlwifi/pcie/drv.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/wireless/intel/iwlwifi/pcie/drv.c b/drivers/net/wireless/intel/iwlwifi/pcie/drv.c
index 93446c37400814e2c27ddd2fe93136862fcf4eee..555323341e7d6d7b94e29b4b4530b056bf6433ec 100644
--- a/drivers/net/wireless/intel/iwlwifi/pcie/drv.c
+++ b/drivers/net/wireless/intel/iwlwifi/pcie/drv.c
@@ -1449,7 +1449,7 @@ iwl_pci_find_dev_info(u16 device, u16 subsystem_device,
* !bw_limit to have a match.
*/
if (dev_info->bw_limit != IWL_CFG_BW_ANY &&
- (dev_info->bw_limit == IWL_CFG_BW_NO_LIM) == !!bw_limit)
+ (dev_info->bw_limit == IWL_CFG_BW_NO_LIM) == !bw_limit)
continue;
if (dev_info->cores != (u8)IWL_CFG_ANY &&
---
base-commit: 0937cb5f345c79d702b4d0d744e2a2529b551cb2
change-id: 20250418-probe-fix-f280c81c2732
Best regards,
--
~ Kurt
next reply other threads:[~2025-04-18 6:29 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-18 6:29 Kurt Borja [this message]
2025-04-19 5:50 ` [PATCH v2] wifi: iwlwifi: pcie: Fix match condition in iwl_pci_find_dev_info() Kurt Borja
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250418-probe-fix-v2-1-ec1ef2d8a534@gmail.com \
--to=kuurtb@gmail.com \
--cc=emmanuel.grumbach@intel.com \
--cc=johannes.berg@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=miriam.rachel.korenblit@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox