Re: [PATCH 0/2] riscv: dts: spacemit: Add clocks to pinctrl and UART

[Yixun Lan <dlan@gentoo.org>]

On 09:42 Sat 19 Apr     , Haylen Chu wrote:
> On Sat, Apr 19, 2025 at 11:32:29AM +0800, Yixun Lan wrote:
> > Populate clock property for pinctrl and UART controller.
> > 
> > The pinctrl's clock dt-binding patch is still waiting to be merged[1].
> > 
> > The UART's dt-binding and driver code has already been accepted[2],
> > so we now are only sending the DT part patch.
> > 
> > These two patches are abased on SpacemiT SoC tree's for-next branch[3]
> > 
> > Link: https://lore.kernel.org/r/20250416-02-k1-pinctrl-clk-v2-0-2b5fcbd4183c@gentoo.org [1]
> > Link: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/tty.git/log/?h=tty-next [2]
> > Link: https://github.com/spacemit-com/linux/tree/for-next [3]
> > Signed-off-by: Yixun Lan <dlan@gentoo.org>
> 
> Generally this looks good to me, but I realized that splitting the
> commit that introduces clock controllers and the one that correctly
> fills clock properties for various peripherals may cause bisectable
> issues, i.e. the UART won't function with only the clock controller
> introduced and no clk_ignore_unused specified on commandline.
> 
I don't think you should worry about this, my plan is to apply
these two patches to for-next branch of spacemiT SoC tree, which
exactly on top of clock patches, besides pinctrl[1], uart[2] patches
will go via different subsystem, and this series depend on them
in order to work properly at run time phase, so regarding this, it's
 kind of broken already.. but if take a high picture that they all
will be merged into for-next/master branch, then it's fine


> If this isn't really a problem, for the whole series,
> 
> Reviewed-by: Haylen Chu <heylenay@4d2.org>
> 
> > ---
> > Yixun Lan (2):
> >       riscv: dts: spacemit: Acquire clocks for pinctrl
> >       riscv: dts: spacemit: Acquire clocks for UART
> > 
> >  arch/riscv/boot/dts/spacemit/k1.dtsi | 39 +++++++++++++++++++++++++++---------
> >  1 file changed, 30 insertions(+), 9 deletions(-)
> > ---
> > base-commit: 279d51ad9f6dc0c667f6f141a669b2c921277d1a
> > change-id: 20250419-05-dts-clock-026bfca75e5b
> > 
> > Best regards,
> > -- 
> > Yixun Lan
> > 
> 

-- 
Yixun Lan (dlan)