* [PATCH] staging: gpib: Fix lpvo request_system_control
@ 2025-04-19 10:52 Dave Penkler
2025-04-22 6:28 ` Dan Carpenter
0 siblings, 1 reply; 2+ messages in thread
From: Dave Penkler @ 2025-04-19 10:52 UTC (permalink / raw)
To: gregkh, linux-staging, linux-kernel; +Cc: marcello.carla, Dave Penkler
The board should not set the controller-in-charge status in
request_system_control. It can only become controller-in-charge
by issuing an interface_clear.
Remove the setting of controller-in-charge from request_system_control.
Fixes: fce79512a96a ("staging: gpib: Add LPVO DIY USB GPIB driver")
Signed-off-by: Dave Penkler <dpenkler@gmail.com>
---
drivers/staging/gpib/lpvo_usb_gpib/lpvo_usb_gpib.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/staging/gpib/lpvo_usb_gpib/lpvo_usb_gpib.c b/drivers/staging/gpib/lpvo_usb_gpib/lpvo_usb_gpib.c
index 2e315c7756c4..3cf5037c0cd2 100644
--- a/drivers/staging/gpib/lpvo_usb_gpib/lpvo_usb_gpib.c
+++ b/drivers/staging/gpib/lpvo_usb_gpib/lpvo_usb_gpib.c
@@ -916,7 +916,6 @@ static int usb_gpib_request_system_control(struct gpib_board *board, int request
if (!request_control)
return -EINVAL;
- set_bit(CIC_NUM, &board->status);
DIA_LOG(1, "done with %d -> %lx\n", request_control, board->status);
return 0;
}
--
2.49.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] staging: gpib: Fix lpvo request_system_control
2025-04-19 10:52 [PATCH] staging: gpib: Fix lpvo request_system_control Dave Penkler
@ 2025-04-22 6:28 ` Dan Carpenter
0 siblings, 0 replies; 2+ messages in thread
From: Dan Carpenter @ 2025-04-22 6:28 UTC (permalink / raw)
To: Dave Penkler; +Cc: gregkh, linux-staging, linux-kernel, marcello.carla
On Sat, Apr 19, 2025 at 12:52:54PM +0200, Dave Penkler wrote:
> The board should not set the controller-in-charge status in
> request_system_control. It can only become controller-in-charge
> by issuing an interface_clear.
>
> Remove the setting of controller-in-charge from request_system_control.
>
The commit message needs to say what this bug looks like to the user.
regards,
dan carpetner
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2025-04-22 6:28 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-04-19 10:52 [PATCH] staging: gpib: Fix lpvo request_system_control Dave Penkler
2025-04-22 6:28 ` Dan Carpenter
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox