public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
* [PATCH] genirq: Remove unused  remove_percpu_irq
@ 2025-04-20 16:46 linux
  2025-05-07  9:42 ` [tip: irq/core] genirq: Remove unused remove_percpu_irq() tip-bot2 for Dr. David Alan Gilbert
  0 siblings, 1 reply; 2+ messages in thread
From: linux @ 2025-04-20 16:46 UTC (permalink / raw)
  To: tglx, piliu; +Cc: linux-kernel, Dr. David Alan Gilbert

From: "Dr. David Alan Gilbert" <linux@treblig.org>

remove_percpu_irq() has been unused since it was added in 2011 by
commit 31d9d9b6d830 ("genirq: Add support for per-cpu dev_id interrupts")

Remove it.
(I see Pingfan Liu tried to remove it as part of a series exactly
3 years ago, but don't see anything about why it didn't happen).

Signed-off-by: Dr. David Alan Gilbert <linux@treblig.org>
---
 include/linux/irq.h |  1 -
 kernel/irq/manage.c | 15 ---------------
 2 files changed, 16 deletions(-)

diff --git a/include/linux/irq.h b/include/linux/irq.h
index dd5df1e2d032..d8554da1b226 100644
--- a/include/linux/irq.h
+++ b/include/linux/irq.h
@@ -597,7 +597,6 @@ enum {
 
 struct irqaction;
 extern int setup_percpu_irq(unsigned int irq, struct irqaction *new);
-extern void remove_percpu_irq(unsigned int irq, struct irqaction *act);
 
 #ifdef CONFIG_DEPRECATED_IRQ_CPU_ONOFFLINE
 extern void irq_cpu_online(void);
diff --git a/kernel/irq/manage.c b/kernel/irq/manage.c
index 753eef8e041c..30652434724d 100644
--- a/kernel/irq/manage.c
+++ b/kernel/irq/manage.c
@@ -2497,21 +2497,6 @@ static struct irqaction *__free_percpu_irq(unsigned int irq, void __percpu *dev_
 	return NULL;
 }
 
-/**
- *	remove_percpu_irq - free a per-cpu interrupt
- *	@irq: Interrupt line to free
- *	@act: irqaction for the interrupt
- *
- * Used to remove interrupts statically setup by the early boot process.
- */
-void remove_percpu_irq(unsigned int irq, struct irqaction *act)
-{
-	struct irq_desc *desc = irq_to_desc(irq);
-
-	if (desc && irq_settings_is_per_cpu_devid(desc))
-	    __free_percpu_irq(irq, act->percpu_dev_id);
-}
-
 /**
  *	free_percpu_irq - free an interrupt allocated with request_percpu_irq
  *	@irq: Interrupt line to free
-- 
2.49.0


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* [tip: irq/core] genirq: Remove unused remove_percpu_irq()
  2025-04-20 16:46 [PATCH] genirq: Remove unused remove_percpu_irq linux
@ 2025-05-07  9:42 ` tip-bot2 for Dr. David Alan Gilbert
  0 siblings, 0 replies; 2+ messages in thread
From: tip-bot2 for Dr. David Alan Gilbert @ 2025-05-07  9:42 UTC (permalink / raw)
  To: linux-tip-commits
  Cc: Dr. David Alan Gilbert, Thomas Gleixner, x86, linux-kernel, maz

The following commit has been merged into the irq/core branch of tip:

Commit-ID:     aefc11550ebd08eadee6d643792c9092de2e472f
Gitweb:        https://git.kernel.org/tip/aefc11550ebd08eadee6d643792c9092de2e472f
Author:        Dr. David Alan Gilbert <linux@treblig.org>
AuthorDate:    Sun, 20 Apr 2025 17:46:56 +01:00
Committer:     Thomas Gleixner <tglx@linutronix.de>
CommitterDate: Wed, 07 May 2025 11:35:41 +02:00

genirq: Remove unused remove_percpu_irq()

remove_percpu_irq() has been unused since it was added in 2011 by
commit 31d9d9b6d830 ("genirq: Add support for per-cpu dev_id interrupts")

Remove it.

Signed-off-by: Dr. David Alan Gilbert <linux@treblig.org>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Link: https://lore.kernel.org/all/20250420164656.112641-1-linux@treblig.org

---
 include/linux/irq.h |  1 -
 kernel/irq/manage.c | 15 ---------------
 2 files changed, 16 deletions(-)

diff --git a/include/linux/irq.h b/include/linux/irq.h
index df93b23..810e44e 100644
--- a/include/linux/irq.h
+++ b/include/linux/irq.h
@@ -597,7 +597,6 @@ enum {
 
 struct irqaction;
 extern int setup_percpu_irq(unsigned int irq, struct irqaction *new);
-extern void remove_percpu_irq(unsigned int irq, struct irqaction *act);
 
 #ifdef CONFIG_DEPRECATED_IRQ_CPU_ONOFFLINE
 extern void irq_cpu_online(void);
diff --git a/kernel/irq/manage.c b/kernel/irq/manage.c
index 827edc8..e6c6c0a 100644
--- a/kernel/irq/manage.c
+++ b/kernel/irq/manage.c
@@ -2378,21 +2378,6 @@ static struct irqaction *__free_percpu_irq(unsigned int irq, void __percpu *dev_
 }
 
 /**
- * remove_percpu_irq - free a per-cpu interrupt
- * @irq:	Interrupt line to free
- * @act:	irqaction for the interrupt
- *
- * Used to remove interrupts statically setup by the early boot process.
- */
-void remove_percpu_irq(unsigned int irq, struct irqaction *act)
-{
-	struct irq_desc *desc = irq_to_desc(irq);
-
-	if (desc && irq_settings_is_per_cpu_devid(desc))
-		__free_percpu_irq(irq, act->percpu_dev_id);
-}
-
-/**
  * free_percpu_irq - free an interrupt allocated with request_percpu_irq
  * @irq:	Interrupt line to free
  * @dev_id:	Device identity to free

^ permalink raw reply related	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2025-05-07  9:42 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-04-20 16:46 [PATCH] genirq: Remove unused remove_percpu_irq linux
2025-05-07  9:42 ` [tip: irq/core] genirq: Remove unused remove_percpu_irq() tip-bot2 for Dr. David Alan Gilbert

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox