* [PATCH] tty: Remove unused API tty_port_register_device_serdev()
@ 2025-04-23 14:40 Zijun Hu
2025-04-24 8:41 ` Jiri Slaby
0 siblings, 1 reply; 2+ messages in thread
From: Zijun Hu @ 2025-04-23 14:40 UTC (permalink / raw)
To: Greg Kroah-Hartman, Jiri Slaby
Cc: Zijun Hu, linux-kernel, linux-serial, Zijun Hu
From: Zijun Hu <quic_zijuhu@quicinc.com>
Remove API tty_port_register_device_serdev() which has no caller.
Signed-off-by: Zijun Hu <quic_zijuhu@quicinc.com>
---
drivers/tty/tty_port.c | 20 --------------------
include/linux/tty_port.h | 3 ---
2 files changed, 23 deletions(-)
diff --git a/drivers/tty/tty_port.c b/drivers/tty/tty_port.c
index 14cca33d226930f56ecbcce0d8ad8e90df8eee4f..4af1fbf73f51ca6eb321e7bf507a1cde74442b89 100644
--- a/drivers/tty/tty_port.c
+++ b/drivers/tty/tty_port.c
@@ -199,26 +199,6 @@ struct device *tty_port_register_device_attr_serdev(struct tty_port *port,
}
EXPORT_SYMBOL_GPL(tty_port_register_device_attr_serdev);
-/**
- * tty_port_register_device_serdev - register tty or serdev device
- * @port: tty_port of the device
- * @driver: tty_driver for this device
- * @index: index of the tty
- * @host: serial port hardware controller device
- * @parent: parent if exists, otherwise NULL
- *
- * Register a serdev or tty device depending on if the parent device has any
- * defined serdev clients or not.
- */
-struct device *tty_port_register_device_serdev(struct tty_port *port,
- struct tty_driver *driver, unsigned index,
- struct device *host, struct device *parent)
-{
- return tty_port_register_device_attr_serdev(port, driver, index,
- host, parent, NULL, NULL);
-}
-EXPORT_SYMBOL_GPL(tty_port_register_device_serdev);
-
/**
* tty_port_unregister_device - deregister a tty or serdev device
* @port: tty_port of the device
diff --git a/include/linux/tty_port.h b/include/linux/tty_port.h
index 1b861f2100b69f120971c7dd503d6635db1fb468..08f89a59836621b2c8864c46c4ed8883b3f9045b 100644
--- a/include/linux/tty_port.h
+++ b/include/linux/tty_port.h
@@ -147,9 +147,6 @@ struct device *tty_port_register_device_attr(struct tty_port *port,
struct tty_driver *driver, unsigned index,
struct device *device, void *drvdata,
const struct attribute_group **attr_grp);
-struct device *tty_port_register_device_serdev(struct tty_port *port,
- struct tty_driver *driver, unsigned index,
- struct device *host, struct device *parent);
struct device *tty_port_register_device_attr_serdev(struct tty_port *port,
struct tty_driver *driver, unsigned index,
struct device *host, struct device *parent, void *drvdata,
---
base-commit: 0af2f6be1b4281385b618cb86ad946eded089ac8
change-id: 20250423-remove_api-25bc6083086e
Best regards,
--
Zijun Hu <quic_zijuhu@quicinc.com>
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] tty: Remove unused API tty_port_register_device_serdev()
2025-04-23 14:40 [PATCH] tty: Remove unused API tty_port_register_device_serdev() Zijun Hu
@ 2025-04-24 8:41 ` Jiri Slaby
0 siblings, 0 replies; 2+ messages in thread
From: Jiri Slaby @ 2025-04-24 8:41 UTC (permalink / raw)
To: Zijun Hu, Greg Kroah-Hartman; +Cc: linux-kernel, linux-serial, Zijun Hu
On 23. 04. 25, 16:40, Zijun Hu wrote:
> From: Zijun Hu <quic_zijuhu@quicinc.com>
>
> Remove API tty_port_register_device_serdev() which has no caller.
>
> Signed-off-by: Zijun Hu <quic_zijuhu@quicinc.com>
Reviewed-by: Jiri Slaby <jirislaby@kernel.org>
thanks,
--
js
suse labs
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2025-04-24 8:42 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-04-23 14:40 [PATCH] tty: Remove unused API tty_port_register_device_serdev() Zijun Hu
2025-04-24 8:41 ` Jiri Slaby
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox