From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F0E521514E4 for ; Wed, 23 Apr 2025 06:45:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1745390717; cv=none; b=RAzTKudy9syMS/6UfaozHqJq/sCvlEesNQANoDfy+uZBwrUxZbykNDSeP0qLeoJSkjdcjAi+pFJy4LrpXCj5Er+AkoAK5qRj04GBSAsLXSvmxfBjJwyXUE657LdOxsUnH9Yf0RYevRFSFj1W3ad3dPeAAFwZC8i3XAznUF8nfC8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1745390717; c=relaxed/simple; bh=h3D+v7S/DE8v4VXSLO4J78ijDrD37ur1IijJWbA1kPc=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=jezYbP9Y06PdtT+QBYsOuiBbbS7CwQmHymM9Hzt7oFLEa+4VDF6yvhYWuMXyS3il8acJevvj+hIyFabuEzU1M0rSE3bgO5gYB1sHod3KcVKesOd6osQLKEZx6ZcGTdy4TdaDiMe31Ew4QivE56Rdru2F3973V/ACdJ1TSNLwyfU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=Q3h7bnKm; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="Q3h7bnKm" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1745390715; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=FJQr5daKI6/1i+nwgHlDoYSZzm+JP1wEk08aCiKUf8w=; b=Q3h7bnKmngwiwDGhGcvcuCrj9oeQ8wf9e19z4HIngNfOMsITGqb03rV6rjzFGGqIhyoz45 +EQG+peZ4D7qYySnweXAmMyi1/oVbI4mjvmpd0Dx5Uiu+UPsJ1P44BGe/7Rvxk7Y6eN2Cs nE2i8JNY/Ma/iJE1FBTwAZ9dn3u/Xww= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-142-7m5xpZt4PuOLp3i3eWG0Zw-1; Wed, 23 Apr 2025 02:45:13 -0400 X-MC-Unique: 7m5xpZt4PuOLp3i3eWG0Zw-1 X-Mimecast-MFC-AGG-ID: 7m5xpZt4PuOLp3i3eWG0Zw_1745390712 Received: by mail-wm1-f71.google.com with SMTP id 5b1f17b1804b1-43d4d15058dso43028715e9.0 for ; Tue, 22 Apr 2025 23:45:13 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1745390712; x=1745995512; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=FJQr5daKI6/1i+nwgHlDoYSZzm+JP1wEk08aCiKUf8w=; b=fP4Zm+roQT5wCosRD+ehcNr/WtBwMQNcXP40Eb1Rs7jE2zTnqFuDoTs7BOLIOUwRKo GW8UNLCJQz8ptBIUtVpGYQ49msztIAatTmG+mxTax58Ti7ipeehz0vhj79JcqCVInLSw bRy4cXxVuMHRlXufeDEVGQD55QMBp+O+gCeMlhlpGUvAEhP8yuighWnTnp8yQiosipGX 0b5HbQm2aZSxGED3Xe7Paroktd2OgszBa00eP2+zPVsjctFsoZ6AVvCYOoIfS+pQPAEH Wujhu38lYRUV5rNmx1kBhqE5RTRJ5K3nb3l1Rakea24Frqzz/eB0nUEP7pba4ZNDEOso H+GQ== X-Forwarded-Encrypted: i=1; AJvYcCUwDRVAereYLqjheno3QdB55/FYpuVWJwhM82sckRMf9ud53tFfKW8LcLtBfAoVaagz90QCJGxQD+mvyuc=@vger.kernel.org X-Gm-Message-State: AOJu0YxXue+efBqtpPQhL9nHhAekUZtMALBMvHyENXTPRHJkfnDVlQav cp43cbRNu9CpZO7By9PVXg7/ykdcnwQKXy2UL2jvudfkYbWfz+p1AWiszSCNd1upr3YDBGhBJc9 U4lK3DWjnNCrYojrTVOhaBrFWBWyx4r4sA6O6TtPyAZR8qfvEAijqzMxdQ8clfg== X-Gm-Gg: ASbGncuMDZBCk1f4iZ/pcdjHq1lye+ewz/d1UWZJNgx+AUS5kSS08MYwP/94qHHqQSQ juZKKMjXv7GyjNuzFEqUQBTewMqGmS6VhYjq4Qwe2fMsM8O7wSQC78HLaaixEpvL9NI7y5XXRQD fjBiht+fDNUdBe7bQFgq+LNnpF0SE5I40KMZpe6OCeq1ST98TgiUoNYvHgx485/fhLy51gO+rpt b7oTazIhXwIBkAbzO4tVKA6EdhPNURgXW0WB2V7TaGIaGVAVh6aOH+HWnQX7rOzLxKB4uHfjIq/ jVbQnw== X-Received: by 2002:a05:600c:3487:b0:43e:a7c9:8d2b with SMTP id 5b1f17b1804b1-4406abfab7dmr152587645e9.24.1745390712285; Tue, 22 Apr 2025 23:45:12 -0700 (PDT) X-Google-Smtp-Source: AGHT+IESPeBSydPIH0zVAjW7EqTg1hmkncqgVOAhXdcSWQ91oQ3uYj81WGlTIQYk3qbwlXLCw+komw== X-Received: by 2002:a05:600c:3487:b0:43e:a7c9:8d2b with SMTP id 5b1f17b1804b1-4406abfab7dmr152587385e9.24.1745390711947; Tue, 22 Apr 2025 23:45:11 -0700 (PDT) Received: from redhat.com ([2a0d:6fc0:1517:1000:ea83:8e5f:3302:3575]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-44092d4707csm14014875e9.40.2025.04.22.23.45.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 22 Apr 2025 23:45:11 -0700 (PDT) Date: Wed, 23 Apr 2025 02:45:08 -0400 From: "Michael S. Tsirkin" To: Eric Auger Cc: Gerd Hoffmann , linux-kernel@vger.kernel.org, Eric Auger , Jocelyn Falempe , David Airlie , Gurchetan Singh , Chia-I Wu , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , Simona Vetter , Jason Wang , Xuan Zhuo , Eugenio =?iso-8859-1?Q?P=E9rez?= , dri-devel@lists.freedesktop.org, virtualization@lists.linux.dev Subject: Re: [PATCH v2] virtgpu: don't reset on shutdown Message-ID: <20250423023922-mutt-send-email-mst@kernel.org> References: <8490dbeb6f79ed039e6c11d121002618972538a3.1744293540.git.mst@redhat.com> <20250415095922-mutt-send-email-mst@kernel.org> <5aede4c4-5dfd-4ec1-9fd8-a5d6700678bd@redhat.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <5aede4c4-5dfd-4ec1-9fd8-a5d6700678bd@redhat.com> On Tue, Apr 22, 2025 at 06:49:04PM +0200, Eric Auger wrote: > Hi Gerd, Michael, > > On 4/16/25 3:57 PM, Gerd Hoffmann wrote: > > On Tue, Apr 15, 2025 at 10:00:48AM -0400, Michael S. Tsirkin wrote: > >> On Tue, Apr 15, 2025 at 01:16:32PM +0200, Gerd Hoffmann wrote: > >>> Hi, > >>> > >>>> +static void virtio_gpu_shutdown(struct virtio_device *vdev) > >>>> +{ > >>>> + /* > >>>> + * drm does its own synchronization on shutdown. > >>>> + * Do nothing here, opt out of device reset. > >>>> + */ > >>> I think a call to 'drm_dev_unplug()' is what you need here. > >>> > >>> take care, > >>> Gerd > >> My patch reverts the behaviour back to what it was, so pls go > >> ahead and send a patch on top? I won't be able to explain > >> what it does and why it's needed. > > See below. Untested. > > > > Eric, can you give this a spin? > > > > thanks, > > Gerd > > > > ----------------------- cut here ------------------------------- > > From f3051dd52cb2004232941e6d2cbc0c694e290534 Mon Sep 17 00:00:00 2001 > > From: Gerd Hoffmann > > Date: Wed, 16 Apr 2025 15:53:04 +0200 > > Subject: [PATCH] drm/virtio: implement virtio_gpu_shutdown > > > > Calling drm_dev_unplug() is the drm way to say the device > > is gone and can not be accessed any more. > > > > Signed-off-by: Gerd Hoffmann > > --- > > drivers/gpu/drm/virtio/virtgpu_drv.c | 8 ++++---- > > 1 file changed, 4 insertions(+), 4 deletions(-) > > > > diff --git a/drivers/gpu/drm/virtio/virtgpu_drv.c b/drivers/gpu/drm/virtio/virtgpu_drv.c > > index e32e680c7197..71c6ccad4b99 100644 > > --- a/drivers/gpu/drm/virtio/virtgpu_drv.c > > +++ b/drivers/gpu/drm/virtio/virtgpu_drv.c > > @@ -130,10 +130,10 @@ static void virtio_gpu_remove(struct virtio_device *vdev) > > > > static void virtio_gpu_shutdown(struct virtio_device *vdev) > > { > > - /* > > - * drm does its own synchronization on shutdown. > > - * Do nothing here, opt out of device reset. > > - */ > > + struct drm_device *dev = vdev->priv; > > + > > + /* stop talking to the device */ > > + drm_dev_unplug(dev); > I have tested this patch on top of Michael's v2 and I don't see any > splat on guest. > > Feel free to add my > > Reviewed-by: Eric Auger > Tested-by: Eric Auger > > Thanks > > Eric Thanks, Eric! Gerd, do you want to post a patch officially? I just sent the dependency to Linus, maybe mention this for the maintainers. > > } > > > > static void virtio_gpu_config_changed(struct virtio_device *vdev)