From: Philipp Stanner <phasta@kernel.org>
To: Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
Jaya Kumar <jayakumar.alsa@gmail.com>,
Clemens Ladisch <clemens@ladisch.de>,
Colin Ian King <colin.i.king@gmail.com>,
Philipp Stanner <phasta@kernel.org>,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
Jerome Brunet <jbrunet@baylibre.com>,
Mark Brown <broonie@kernel.org>,
liujing <liujing@cmss.chinamobile.com>,
Andres Urian Florez <andres.emb.sys@gmail.com>,
Oswald Buddenhagen <oswald.buddenhagen@gmx.de>,
Thorsten Blum <thorsten.blum@linux.dev>,
David Rhodes <drhodes@opensource.cirrus.com>,
Ingo Molnar <mingo@kernel.org>,
Thomas Gleixner <tglx@linutronix.de>
Cc: linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH v2 28/28] ALSA: maestro3: Use pure devres PCI
Date: Wed, 23 Apr 2025 09:53:46 +0200 [thread overview]
Message-ID: <20250423075346.45907-29-phasta@kernel.org> (raw)
In-Reply-To: <20250423075346.45907-1-phasta@kernel.org>
pci_request_regions() is a hybrid function which becomes managed if
pcim_enable_device() was called before. This hybrid nature is deprecated
and should not be used anymore.
Replace pci_request_regions() with the always-managed function
pcim_request_all_regions().
Signed-off-by: Philipp Stanner <phasta@kernel.org>
Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
sound/pci/maestro3.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/sound/pci/maestro3.c b/sound/pci/maestro3.c
index f4d211970d7e..e61e15774706 100644
--- a/sound/pci/maestro3.c
+++ b/sound/pci/maestro3.c
@@ -2552,7 +2552,7 @@ snd_m3_create(struct snd_card *card, struct pci_dev *pci,
if (err < 0)
return err;
- err = pci_request_regions(pci, card->driver);
+ err = pcim_request_all_regions(pci, card->driver);
if (err < 0)
return err;
--
2.48.1
next prev parent reply other threads:[~2025-04-23 7:56 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-23 7:53 [PATCH v2 00/28] ALSA: Phase out hybrid PCI devres API Philipp Stanner
2025-04-23 7:53 ` [PATCH v2 01/28] ALSA: sonicvibes: Use pure devres PCI Philipp Stanner
2025-04-23 7:53 ` [PATCH v2 02/28] ALSA: rme96: " Philipp Stanner
2025-04-23 7:53 ` [PATCH v2 03/28] ALSA: rme32: " Philipp Stanner
2025-04-23 7:53 ` [PATCH v2 04/28] ALSA: ens1370: " Philipp Stanner
2025-04-23 7:53 ` [PATCH v2 05/28] ALSA: cmipci: " Philipp Stanner
2025-04-23 7:53 ` [PATCH v2 06/28] ALSA: via82: " Philipp Stanner
2025-04-23 7:53 ` [PATCH v2 07/28] ALSA: sis7019: " Philipp Stanner
2025-04-23 7:53 ` [PATCH v2 08/28] ALSA: intel8x: " Philipp Stanner
2025-04-23 7:53 ` [PATCH v2 09/28] ALSA: fm801: " Philipp Stanner
2025-04-23 7:53 ` [PATCH v2 10/28] ALSA: es19x8: " Philipp Stanner
2025-04-23 7:53 ` [PATCH v2 11/28] ALSA: azt3328: " Philipp Stanner
2025-04-23 7:53 ` [PATCH v2 12/28] ALSA: als: " Philipp Stanner
2025-04-23 7:53 ` [PATCH v2 13/28] ALSA: oxygen: " Philipp Stanner
2025-04-23 7:53 ` [PATCH v2 14/28] ALSA: lx6464es: " Philipp Stanner
2025-04-23 7:53 ` [PATCH v2 15/28] ALSA: vx222: " Philipp Stanner
2025-04-23 7:53 ` [PATCH v2 16/28] ALSA: trident: " Philipp Stanner
2025-04-23 7:53 ` [PATCH v2 17/28] ALSA: rme9652: " Philipp Stanner
2025-04-23 7:53 ` [PATCH v2 18/28] ALSA: ymfpci: " Philipp Stanner
2025-04-23 7:53 ` [PATCH v2 19/28] ALSA: riptide: " Philipp Stanner
2025-04-23 7:53 ` [PATCH v2 20/28] ALSA: nm256: " Philipp Stanner
2025-04-23 7:53 ` [PATCH v2 21/28] ALSA: ice: " Philipp Stanner
2025-04-23 7:53 ` [PATCH v2 22/28] ALSA: emu10k1: " Philipp Stanner
2025-04-23 7:53 ` [PATCH v2 23/28] ALSA: echoaudio: " Philipp Stanner
2025-04-23 7:53 ` [PATCH v2 24/28] ALSA: cs5535: " Philipp Stanner
2025-04-23 7:53 ` [PATCH v2 25/28] ALSA: cs46xx: " Philipp Stanner
2025-04-23 7:53 ` [PATCH v2 26/28] ALSA: ca0106: " Philipp Stanner
2025-04-23 7:53 ` [PATCH v2 27/28] ALSA: ali5451: " Philipp Stanner
2025-04-23 7:53 ` Philipp Stanner [this message]
2025-04-24 7:23 ` [PATCH v2 00/28] ALSA: Phase out hybrid PCI devres API Takashi Iwai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250423075346.45907-29-phasta@kernel.org \
--to=phasta@kernel.org \
--cc=andres.emb.sys@gmail.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=broonie@kernel.org \
--cc=clemens@ladisch.de \
--cc=colin.i.king@gmail.com \
--cc=drhodes@opensource.cirrus.com \
--cc=jayakumar.alsa@gmail.com \
--cc=jbrunet@baylibre.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=liujing@cmss.chinamobile.com \
--cc=mingo@kernel.org \
--cc=oswald.buddenhagen@gmx.de \
--cc=perex@perex.cz \
--cc=tglx@linutronix.de \
--cc=thorsten.blum@linux.dev \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox