From: Kees Cook <kees@kernel.org>
To: Arnd Bergmann <arnd@kernel.org>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Alejandro Colomar <alx@kernel.org>, Arnd Bergmann <arnd@arndb.de>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] eisa: address link failure
Date: Wed, 23 Apr 2025 12:24:46 -0700 [thread overview]
Message-ID: <202504231224.1A2A116@keescook> (raw)
In-Reply-To: <20250423162755.2174698-1-arnd@kernel.org>
On Wed, Apr 23, 2025 at 06:27:50PM +0200, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@arndb.de>
>
> The devlist.h file is generated at build time but is not an object file,
> so linking fails, at least in some configurations:
>
> ld.lld-21: error: vmlinux.a(drivers/eisa/devlist.h): not an ELF file
>
> Make this an extra-y instead of obj-y target in Kbuild.
>
> Fixes: dd09eb0e2cc4 ("EISA: Increase length of device names")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Thanks! I already sent this one:
https://lore.kernel.org/all/20250423023743.work.350-kees@kernel.org/
-Kees
> ---
> drivers/eisa/Makefile | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/eisa/Makefile b/drivers/eisa/Makefile
> index f0d6cf7d1f32..562d8797e3b4 100644
> --- a/drivers/eisa/Makefile
> +++ b/drivers/eisa/Makefile
> @@ -1,7 +1,8 @@
> # SPDX-License-Identifier: GPL-2.0
> # Makefile for the Linux device tree
>
> -obj-$(CONFIG_EISA) += devlist.h eisa-bus.o
> +obj-$(CONFIG_EISA) += eisa-bus.o
> +extra-$(CONFIG_EISA) += devlist.h
> obj-${CONFIG_EISA_PCI_EISA} += pci_eisa.o
>
> # virtual_root.o should be the last EISA root device to initialize,
> --
> 2.39.5
>
--
Kees Cook
prev parent reply other threads:[~2025-04-23 19:24 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-23 16:27 [PATCH] eisa: address link failure Arnd Bergmann
2025-04-23 19:24 ` Kees Cook [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202504231224.1A2A116@keescook \
--to=kees@kernel.org \
--cc=alx@kernel.org \
--cc=arnd@arndb.de \
--cc=arnd@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox