From: Al Viro <viro@zeniv.linux.org.uk>
To: Kevin Paul Reddy Janagari <kevinpaul468@gmail.com>
Cc: mark@fasheh.com, jlbec@evilplan.org, joseph.qi@linux.alibaba.com,
ocfs2-devel@oss.oracle.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ocfs2: fix deadlock in ocfs2_get_system_file_inode
Date: Thu, 24 Apr 2025 20:46:39 +0100 [thread overview]
Message-ID: <20250424194639.GH2023217@ZenIV> (raw)
In-Reply-To: <20250424162911.51413-1-kevinpaul468@gmail.com>
On Thu, Apr 24, 2025 at 09:59:11PM +0530, Kevin Paul Reddy Janagari wrote:
> This issue can be resolved by making the down_read -> down_read_try
> in the ocfs2_read_virt_blocks.
ITYM "can be papered over by..."; *IF* fill_super() is the only place where
these are taken in such order, this is strictly worse than the current
situation - you are taking a false positive from lockdep (fill_super is
not going to have any other threads accessing the same fs instance) and
adding random failures and syslog spew where none existed.
NAK in that form; it _may_ serve as a stopgap if fill_super is not
the only place where we do it in such order, but even then we need
to deal with the problem properly.
next prev parent reply other threads:[~2025-04-24 19:46 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-24 16:29 [PATCH] ocfs2: fix deadlock in ocfs2_get_system_file_inode Kevin Paul Reddy Janagari
2025-04-24 19:46 ` Al Viro [this message]
-- strict thread matches above, loose matches on Subject: below --
2024-09-21 17:50 [PATCH] ocfs2: Fix " Mohammed Anees
2024-09-23 2:51 ` Joseph Qi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250424194639.GH2023217@ZenIV \
--to=viro@zeniv.linux.org.uk \
--cc=jlbec@evilplan.org \
--cc=joseph.qi@linux.alibaba.com \
--cc=kevinpaul468@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mark@fasheh.com \
--cc=ocfs2-devel@oss.oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox