From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Naman Jain <namjain@linux.microsoft.com>
Cc: "K . Y . Srinivasan" <kys@microsoft.com>,
Haiyang Zhang <haiyangz@microsoft.com>,
Wei Liu <wei.liu@kernel.org>, Dexuan Cui <decui@microsoft.com>,
Stephen Hemminger <stephen@networkplumber.org>,
linux-hyperv@vger.kernel.org, linux-kernel@vger.kernel.org,
stable@kernel.org, Saurabh Sengar <ssengar@linux.microsoft.com>,
Michael Kelley <mhklinux@outlook.com>
Subject: Re: [PATCH v6 0/2] uio_hv_generic: Fix ring buffer sysfs creation path
Date: Fri, 25 Apr 2025 16:00:48 +0200 [thread overview]
Message-ID: <2025042501-accuracy-uncombed-cb99@gregkh> (raw)
In-Reply-To: <20250424053524.1631-1-namjain@linux.microsoft.com>
On Thu, Apr 24, 2025 at 11:05:22AM +0530, Naman Jain wrote:
> Hi,
> This patch series aims to address the sysfs creation issue for the ring
> buffer by reorganizing the code. Additionally, it updates the ring sysfs
> size to accurately reflect the actual ring buffer size, rather than a
> fixed static value.
>
> PFB change logs:
>
> Changes since v5:
> https://lore.kernel.org/all/20250415164452.170239-1-namjain@linux.microsoft.com/
> * Added Reviewed-By tags from Dexuan. Also, addressed minor comments in
> commit msg of both patches.
> * Missed to remove check for "primary_channel->device_obj->channels_kset" in
> hv_create_ring_sysfs in earlier patch, as suggested by Michael. Did it
> now.
> * Changed type for declaring bin_attrs due to changes introduced by
> commit 9bec944506fa ("sysfs: constify attribute_group::bin_attrs") which
> merged recently. Did not use bin_attrs_new since another change is in
> the queue to change usage of bin_attrs_new to bin_attrs
> (sysfs: finalize the constification of 'struct bin_attribute').
Please fix up to apply cleanly without build warnings:
drivers/hv/vmbus_drv.c:1893:15: error: initializing 'struct bin_attribute **' with an expression of type 'const struct bin_attribute *const[2]' discards qualifiers in nested pointer types [-Werror,-Wincompatible-pointer-types-discards-qualifiers]
1893 | .bin_attrs = vmbus_chan_bin_attrs,
| ^~~~~~~~~~~~~~~~~~~~
1 error generated.
next prev parent reply other threads:[~2025-04-25 14:00 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-24 5:35 [PATCH v6 0/2] uio_hv_generic: Fix ring buffer sysfs creation path Naman Jain
2025-04-24 5:35 ` [PATCH v6 1/2] uio_hv_generic: Fix sysfs creation path for ring buffer Naman Jain
2025-04-24 5:35 ` [PATCH v6 2/2] Drivers: hv: Make the sysfs node size for the ring buffer dynamic Naman Jain
2025-04-24 13:48 ` [PATCH v6 0/2] uio_hv_generic: Fix ring buffer sysfs creation path Michael Kelley
2025-04-24 16:13 ` Naman Jain
2025-04-25 14:00 ` Greg Kroah-Hartman [this message]
2025-04-28 9:07 ` Naman Jain
2025-05-01 16:05 ` Greg Kroah-Hartman
2025-05-02 6:01 ` Naman Jain
2025-05-02 6:13 ` Greg Kroah-Hartman
2025-05-02 6:17 ` Naman Jain
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2025042501-accuracy-uncombed-cb99@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=decui@microsoft.com \
--cc=haiyangz@microsoft.com \
--cc=kys@microsoft.com \
--cc=linux-hyperv@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mhklinux@outlook.com \
--cc=namjain@linux.microsoft.com \
--cc=ssengar@linux.microsoft.com \
--cc=stable@kernel.org \
--cc=stephen@networkplumber.org \
--cc=wei.liu@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox