* [PATCH v3] tty: serial: samsung_tty: support 18 uart ports
[not found] <CGME20250417042427epcas5p2df3d35803adcb24da7d83e5df586380d@epcas5p2.samsung.com>
@ 2025-04-17 4:34 ` Faraz Ata
2025-04-17 5:19 ` Krzysztof Kozlowski
0 siblings, 1 reply; 6+ messages in thread
From: Faraz Ata @ 2025-04-17 4:34 UTC (permalink / raw)
To: alim.akhtar, krzk, gregkh, jirislaby
Cc: linux-arm-kernel, linux-samsung-soc, linux-kernel, linux-serial,
dev.tailor, rosa.pila, faraz.ata
ExynosAutov920 SoC supports 18 UART ports, update
the value of UART_NR to accommodate the same.
Signed-off-by: Faraz Ata <faraz.ata@samsung.com>
---
Changes in v3:
- Fixed review comments from Krzysztof
- Link to v2: https://patchwork.kernel.org/project/linux-samsung-soc/patch/20250404135006.1263827-1-faraz.ata@samsung.com/
Changes in v2:
- Rebased on the latest linux-next and added reviewers as per get_maintainer
- Link to v1: https://patchwork.kernel.org/project/linux-samsung-soc/patch/20250312061932.1797993-1-faraz.ata@samsung.com/
drivers/tty/serial/samsung_tty.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/tty/serial/samsung_tty.c b/drivers/tty/serial/samsung_tty.c
index 210fff7164c1..9a5211b730fb 100644
--- a/drivers/tty/serial/samsung_tty.c
+++ b/drivers/tty/serial/samsung_tty.c
@@ -52,7 +52,7 @@
#define S3C24XX_SERIAL_MINOR 64
#ifdef CONFIG_ARM64
-#define UART_NR 12
+#define UART_NR 18
#else
#define UART_NR CONFIG_SERIAL_SAMSUNG_UARTS
#endif
--
2.34.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH v3] tty: serial: samsung_tty: support 18 uart ports
2025-04-17 4:34 ` [PATCH v3] tty: serial: samsung_tty: support 18 uart ports Faraz Ata
@ 2025-04-17 5:19 ` Krzysztof Kozlowski
2025-04-17 5:32 ` Faraz Ata
0 siblings, 1 reply; 6+ messages in thread
From: Krzysztof Kozlowski @ 2025-04-17 5:19 UTC (permalink / raw)
To: Faraz Ata, alim.akhtar, gregkh, jirislaby
Cc: linux-arm-kernel, linux-samsung-soc, linux-kernel, linux-serial,
dev.tailor, rosa.pila
On 17/04/2025 06:34, Faraz Ata wrote:
> ExynosAutov920 SoC supports 18 UART ports, update
> the value of UART_NR to accommodate the same.
>
> Signed-off-by: Faraz Ata <faraz.ata@samsung.com>
> ---
> Changes in v3:
> - Fixed review comments from Krzysztof
Which ones? What changed?
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 6+ messages in thread
* RE: [PATCH v3] tty: serial: samsung_tty: support 18 uart ports
2025-04-17 5:19 ` Krzysztof Kozlowski
@ 2025-04-17 5:32 ` Faraz Ata
2025-04-25 11:39 ` Greg KH
0 siblings, 1 reply; 6+ messages in thread
From: Faraz Ata @ 2025-04-17 5:32 UTC (permalink / raw)
To: 'Krzysztof Kozlowski', alim.akhtar, gregkh, jirislaby
Cc: linux-arm-kernel, linux-samsung-soc, linux-kernel, linux-serial,
dev.tailor, rosa.pila
Hello Krzysztof
> -----Original Message-----
> From: Krzysztof Kozlowski <krzk@kernel.org>
> Sent: Thursday, April 17, 2025 10:50 AM
> To: Faraz Ata <faraz.ata@samsung.com>; alim.akhtar@samsung.com;
> gregkh@linuxfoundation.org; jirislaby@kernel.org
> Cc: linux-arm-kernel@lists.infradead.org; linux-samsung-
> soc@vger.kernel.org; linux-kernel@vger.kernel.org; linux-
> serial@vger.kernel.org; dev.tailor@samsung.com; rosa.pila@samsung.com
> Subject: Re: [PATCH v3] tty: serial: samsung_tty: support 18 uart ports
>
> On 17/04/2025 06:34, Faraz Ata wrote:
> > ExynosAutov920 SoC supports 18 UART ports, update the value of
> UART_NR
> > to accommodate the same.
> >
> > Signed-off-by: Faraz Ata <faraz.ata@samsung.com>
> > ---
> > Changes in v3:
> > - Fixed review comments from Krzysztof
>
> Which ones? What changed?
>
While sending v2 change log was missed unintentionally.
Added missed change log in v3.
>
> Best regards,
> Krzysztof
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v3] tty: serial: samsung_tty: support 18 uart ports
2025-04-17 5:32 ` Faraz Ata
@ 2025-04-25 11:39 ` Greg KH
2025-04-28 12:14 ` Faraz Ata
0 siblings, 1 reply; 6+ messages in thread
From: Greg KH @ 2025-04-25 11:39 UTC (permalink / raw)
To: Faraz Ata
Cc: 'Krzysztof Kozlowski', alim.akhtar, jirislaby,
linux-arm-kernel, linux-samsung-soc, linux-kernel, linux-serial,
dev.tailor, rosa.pila
On Thu, Apr 17, 2025 at 11:02:24AM +0530, Faraz Ata wrote:
> Hello Krzysztof
>
> > -----Original Message-----
> > From: Krzysztof Kozlowski <krzk@kernel.org>
> > Sent: Thursday, April 17, 2025 10:50 AM
> > To: Faraz Ata <faraz.ata@samsung.com>; alim.akhtar@samsung.com;
> > gregkh@linuxfoundation.org; jirislaby@kernel.org
> > Cc: linux-arm-kernel@lists.infradead.org; linux-samsung-
> > soc@vger.kernel.org; linux-kernel@vger.kernel.org; linux-
> > serial@vger.kernel.org; dev.tailor@samsung.com; rosa.pila@samsung.com
> > Subject: Re: [PATCH v3] tty: serial: samsung_tty: support 18 uart ports
> >
> > On 17/04/2025 06:34, Faraz Ata wrote:
> > > ExynosAutov920 SoC supports 18 UART ports, update the value of
> > UART_NR
> > > to accommodate the same.
> > >
> > > Signed-off-by: Faraz Ata <faraz.ata@samsung.com>
> > > ---
> > > Changes in v3:
> > > - Fixed review comments from Krzysztof
> >
> > Which ones? What changed?
> >
> While sending v2 change log was missed unintentionally.
> Added missed change log in v3.
Can you add this properly and send a v4?
thanks,
greg k-h
^ permalink raw reply [flat|nested] 6+ messages in thread
* RE: [PATCH v3] tty: serial: samsung_tty: support 18 uart ports
2025-04-25 11:39 ` Greg KH
@ 2025-04-28 12:14 ` Faraz Ata
2025-04-28 17:10 ` 'Greg KH'
0 siblings, 1 reply; 6+ messages in thread
From: Faraz Ata @ 2025-04-28 12:14 UTC (permalink / raw)
To: 'Greg KH'
Cc: 'Krzysztof Kozlowski', alim.akhtar, jirislaby,
linux-arm-kernel, linux-samsung-soc, linux-kernel, linux-serial,
dev.tailor, rosa.pila
HI Greg
> Subject: Re: [PATCH v3] tty: serial: samsung_tty: support 18 uart ports
>
> On Thu, Apr 17, 2025 at 11:02:24AM +0530, Faraz Ata wrote:
> > Hello Krzysztof
> >
> > > -----Original Message-----
> > > From: Krzysztof Kozlowski <krzk@kernel.org>
> > > Sent: Thursday, April 17, 2025 10:50 AM
> > > To: Faraz Ata <faraz.ata@samsung.com>; alim.akhtar@samsung.com;
> > > gregkh@linuxfoundation.org; jirislaby@kernel.org
> > > Cc: linux-arm-kernel@lists.infradead.org; linux-samsung-
> > > soc@vger.kernel.org; linux-kernel@vger.kernel.org; linux-
> > > serial@vger.kernel.org; dev.tailor@samsung.com;
> > > rosa.pila@samsung.com
> > > Subject: Re: [PATCH v3] tty: serial: samsung_tty: support 18 uart
> > > ports
> > >
> > > On 17/04/2025 06:34, Faraz Ata wrote:
> > > > ExynosAutov920 SoC supports 18 UART ports, update the value of
> > > UART_NR
> > > > to accommodate the same.
> > > >
> > > > Signed-off-by: Faraz Ata <faraz.ata@samsung.com>
> > > > ---
> > > > Changes in v3:
> > > > - Fixed review comments from Krzysztof
> > >
> > > Which ones? What changed?
> > >
> > While sending v2 change log was missed unintentionally.
> > Added missed change log in v3.
>
> Can you add this properly and send a v4?
>
This was a clarification given to Krzysztof.
The complete change-log was missed in v2, This was pointed out by Krzysztof.
Added those missed changes in v3.
Do you want me to add this clarification as well and send v4 ?
> thanks,
>
> greg k-h
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v3] tty: serial: samsung_tty: support 18 uart ports
2025-04-28 12:14 ` Faraz Ata
@ 2025-04-28 17:10 ` 'Greg KH'
0 siblings, 0 replies; 6+ messages in thread
From: 'Greg KH' @ 2025-04-28 17:10 UTC (permalink / raw)
To: Faraz Ata
Cc: 'Krzysztof Kozlowski', alim.akhtar, jirislaby,
linux-arm-kernel, linux-samsung-soc, linux-kernel, linux-serial,
dev.tailor, rosa.pila
On Mon, Apr 28, 2025 at 05:44:21PM +0530, Faraz Ata wrote:
> HI Greg
>
> > Subject: Re: [PATCH v3] tty: serial: samsung_tty: support 18 uart ports
> >
> > On Thu, Apr 17, 2025 at 11:02:24AM +0530, Faraz Ata wrote:
> > > Hello Krzysztof
> > >
> > > > -----Original Message-----
> > > > From: Krzysztof Kozlowski <krzk@kernel.org>
> > > > Sent: Thursday, April 17, 2025 10:50 AM
> > > > To: Faraz Ata <faraz.ata@samsung.com>; alim.akhtar@samsung.com;
> > > > gregkh@linuxfoundation.org; jirislaby@kernel.org
> > > > Cc: linux-arm-kernel@lists.infradead.org; linux-samsung-
> > > > soc@vger.kernel.org; linux-kernel@vger.kernel.org; linux-
> > > > serial@vger.kernel.org; dev.tailor@samsung.com;
> > > > rosa.pila@samsung.com
> > > > Subject: Re: [PATCH v3] tty: serial: samsung_tty: support 18 uart
> > > > ports
> > > >
> > > > On 17/04/2025 06:34, Faraz Ata wrote:
> > > > > ExynosAutov920 SoC supports 18 UART ports, update the value of
> > > > UART_NR
> > > > > to accommodate the same.
> > > > >
> > > > > Signed-off-by: Faraz Ata <faraz.ata@samsung.com>
> > > > > ---
> > > > > Changes in v3:
> > > > > - Fixed review comments from Krzysztof
> > > >
> > > > Which ones? What changed?
> > > >
> > > While sending v2 change log was missed unintentionally.
> > > Added missed change log in v3.
> >
> > Can you add this properly and send a v4?
> >
> This was a clarification given to Krzysztof.
> The complete change-log was missed in v2, This was pointed out by Krzysztof.
> Added those missed changes in v3.
> Do you want me to add this clarification as well and send v4 ?
Yes please.
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2025-04-28 17:10 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <CGME20250417042427epcas5p2df3d35803adcb24da7d83e5df586380d@epcas5p2.samsung.com>
2025-04-17 4:34 ` [PATCH v3] tty: serial: samsung_tty: support 18 uart ports Faraz Ata
2025-04-17 5:19 ` Krzysztof Kozlowski
2025-04-17 5:32 ` Faraz Ata
2025-04-25 11:39 ` Greg KH
2025-04-28 12:14 ` Faraz Ata
2025-04-28 17:10 ` 'Greg KH'
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).