Re: [RFC][PATCH 2/2] treewide: Have the task->flags & PF_KTHREAD check use the helper functions

Tejun Heo
2025-04-28T18:34:46Z

On Fri, Apr 25, 2025 at 08:22:59PM -0700, Alexei Starovoitov wrote:
> > > tools/sched_ext/scx_central.bpf.c | 2 +-
> > > tools/sched_ext/scx_flatcg.bpf.c | 2 +-
> > > tools/sched_ext/scx_qmap.bpf.c | 2 +-
> >
> > I think these are fine. The Makefile is pulling in standard kbuild
> > Makefiles, so I think the correct include directories (outside of
> > tools/) are being used.
>
> I suspect they are not fine.
> I don't think they #include linux/sched.h
> I would drop them for now.

Oh, this won't work. Those get all the kernel defs from the BTF generated
vmlinux.h file which doesn't include any inline functions or macros, so
please don't include them in this conversion.

Thanks.

--
tejun