Re: [PATCH 1/3] wifi: rtlwifi: Remove unused rtl_usb_{resume|suspend}

Dr. David Alan Gilbert
2025-05-05T01:39:30Z

* Ping-Ke Shih (pkshih@realtek.com) wrote:
> linux@treblig.org wrote:
>
> > From: "Dr. David Alan Gilbert" <linux@treblig.org>
> >
> > rtl_usb_resume() and rtl_usb_suspend() are trivial stubs that were
> > added in 2011's
> > commit 2ca20f79e0d8 ("rtlwifi: Add usb driver")
> > but aren't wired up anywhere (though commit 442888c706e9 ("rtlwifi:
> > rtl8192cu: Add routines dm, fw, led and sw") added commented
> > out assignments).
> >
> > Remove them.
> >
> > Signed-off-by: Dr. David Alan Gilbert <linux@treblig.org>
>
> 3 patch(es) applied to rtw-next branch of rtw.git, thanks.
>
> d559636e382a wifi: rtlwifi: Remove unused rtl_usb_{resume|suspend}
> 2d867b18eb93 wifi: rtlwifi: Remove uncalled stub rtl*_phy_ap_calibrate
> 406dac790c25 wifi: rtlwifi: Remove unused rtl_bb_delay()

Thanks!
Did you see the question in the 0/3 cover letter asking why
rtl8188ee_bt_hw_init() isn't called?

Dave

> ---
> https://github.com/pkshih/rtw.git
>
--
-----Open up your eyes, open up your mind, open up your code -------
/ Dr. David Alan Gilbert | Running GNU/Linux | Happy \
\ dave @ treblig.org | | In Hex /
\ _________________________|_____ http://www.treblig.org |_______/