public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: carlos.bilbao@kernel.org
To: tglx@linutronix.de, seanjc@google.com, jan.glauber@gmail.com
Cc: bilbao@vt.edu, pmladek@suse.com, akpm@linux-foundation.org,
	jani.nikula@intel.com, linux-kernel@vger.kernel.org,
	gregkh@linuxfoundation.org, takakura@valinux.co.jp,
	john.ogness@linutronix.de,
	Carlos Bilbao <carlos.bilbao@kernel.org>
Subject: [PATCH v2 2/2] x86/panic: Add x86_panic_handler as default post-panic behavior
Date: Mon, 28 Apr 2025 16:59:52 -0500	[thread overview]
Message-ID: <20250428215952.1332985-3-carlos.bilbao@kernel.org> (raw)
In-Reply-To: <20250428215952.1332985-1-carlos.bilbao@kernel.org>

From: Carlos Bilbao <carlos.bilbao@kernel.org>

Add function x86_panic_handler() as the default behavior for x86 for
post-panic stage via panic_set_handling(). Instead of busy-wait loop, it
will halt if there's no console to save CPU cycles.

Signed-off-by: Carlos Bilbao (DigitalOcean) <carlos.bilbao@kernel.org>
---
 arch/x86/kernel/setup.c | 12 ++++++++++++
 1 file changed, 12 insertions(+)

diff --git a/arch/x86/kernel/setup.c b/arch/x86/kernel/setup.c
index 9d2a13b37833..3bfef55e9adb 100644
--- a/arch/x86/kernel/setup.c
+++ b/arch/x86/kernel/setup.c
@@ -16,6 +16,7 @@
 #include <linux/initrd.h>
 #include <linux/iscsi_ibft.h>
 #include <linux/memblock.h>
+#include <linux/panic.h>
 #include <linux/panic_notifier.h>
 #include <linux/pci.h>
 #include <linux/root_dev.h>
@@ -837,6 +838,15 @@ static void __init x86_report_nx(void)
 	}
 }
 
+
+static void x86_panic_handler(void)
+{
+	if (console_trylock()) {
+		console_unlock();
+		safe_halt();
+	}
+}
+
 /*
  * Determine if we were loaded by an EFI loader.  If so, then we have also been
  * passed the efi memmap, systab, etc., so we should use these data structures
@@ -1252,6 +1262,8 @@ void __init setup_arch(char **cmdline_p)
 #endif
 
 	unwind_init();
+
+	panic_set_handling(x86_panic_handler, 1);
 }
 
 #ifdef CONFIG_X86_32
-- 
2.47.1


  parent reply	other threads:[~2025-04-28 23:45 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-04-28 21:59 [PATCH v2 0/2] panic: Reduce CPU consumption after panic carlos.bilbao
2025-04-28 21:59 ` [PATCH v2 1/2] panic: Allow for dynamic custom behavior " carlos.bilbao
2025-04-29 14:54   ` Sean Christopherson
2025-04-29 14:25     ` Carlos Bilbao
2025-04-28 21:59 ` carlos.bilbao [this message]
2025-04-29 14:57   ` [PATCH v2 2/2] x86/panic: Add x86_panic_handler as default post-panic behavior Sean Christopherson
2025-04-29 14:25     ` Carlos Bilbao
2025-04-29 16:53   ` John Ogness
2025-04-29 15:25     ` Carlos Bilbao
2025-04-30  7:58       ` John Ogness
2025-05-07 19:56         ` Carlos Bilbao

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250428215952.1332985-3-carlos.bilbao@kernel.org \
    --to=carlos.bilbao@kernel.org \
    --cc=akpm@linux-foundation.org \
    --cc=bilbao@vt.edu \
    --cc=gregkh@linuxfoundation.org \
    --cc=jan.glauber@gmail.com \
    --cc=jani.nikula@intel.com \
    --cc=john.ogness@linutronix.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=pmladek@suse.com \
    --cc=seanjc@google.com \
    --cc=takakura@valinux.co.jp \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox