The Linux Kernel Mailing List
 help / color / mirror / Atom feed
From: Yangtao Li <frank.li@vivo.com>
To: slava@dubeyko.com, glaubitz@physik.fu-berlin.de
Cc: linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
	Yangtao Li <frank.li@vivo.com>
Subject: [PATCH 2/2] hfs: fix to update ctime after rename
Date: Tue, 29 Apr 2025 14:15:16 -0600	[thread overview]
Message-ID: <20250429201517.101323-2-frank.li@vivo.com> (raw)
In-Reply-To: <20250429201517.101323-1-frank.li@vivo.com>

Similar to hfsplus, let's update file ctime after the rename operation
in hfs_rename().

Signed-off-by: Yangtao Li <frank.li@vivo.com>
---
 fs/hfs/dir.c | 15 ++++++++++-----
 1 file changed, 10 insertions(+), 5 deletions(-)

diff --git a/fs/hfs/dir.c b/fs/hfs/dir.c
index 86a6b317b474..3b95bafb3f04 100644
--- a/fs/hfs/dir.c
+++ b/fs/hfs/dir.c
@@ -284,6 +284,7 @@ static int hfs_rename(struct mnt_idmap *idmap, struct inode *old_dir,
 		      struct dentry *old_dentry, struct inode *new_dir,
 		      struct dentry *new_dentry, unsigned int flags)
 {
+	struct inode *inode = d_inode(old_dentry);
 	int res;
 
 	if (flags & ~RENAME_NOREPLACE)
@@ -299,11 +300,15 @@ static int hfs_rename(struct mnt_idmap *idmap, struct inode *old_dir,
 	res = hfs_cat_move(d_inode(old_dentry)->i_ino,
 			   old_dir, &old_dentry->d_name,
 			   new_dir, &new_dentry->d_name);
-	if (!res)
-		hfs_cat_build_key(old_dir->i_sb,
-				  (btree_key *)&HFS_I(d_inode(old_dentry))->cat_key,
-				  new_dir->i_ino, &new_dentry->d_name);
-	return res;
+	if (res)
+		return res;
+
+	hfs_cat_build_key(old_dir->i_sb,
+			  (btree_key *)&HFS_I(d_inode(old_dentry))->cat_key,
+			  new_dir->i_ino, &new_dentry->d_name);
+	inode_set_ctime_current(inode);
+	mark_inode_dirty(inode);
+	return 0;
 }
 
 const struct file_operations hfs_dir_operations = {
-- 
2.39.0


  reply	other threads:[~2025-04-29 19:55 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-04-29 20:15 [PATCH 1/2] hfsplus: fix to update ctime after rename Yangtao Li
2025-04-29 20:15 ` Yangtao Li [this message]
2025-04-29 21:31   ` [PATCH 2/2] hfs: " Viacheslav Dubeyko
2025-05-02  0:03   ` Viacheslav Dubeyko
2025-05-07 14:22     ` 回复: " 李扬韬
2025-05-09 17:51       ` Viacheslav Dubeyko
2025-05-09 19:02         ` Viacheslav Dubeyko
2025-05-10  5:31         ` 回复: " 李扬韬
2025-05-15  1:10           ` Viacheslav Dubeyko
2025-04-29 21:27 ` [PATCH 1/2] hfsplus: " Viacheslav Dubeyko
2025-05-01 12:01   ` 回复: " 李扬韬
2025-05-01 18:57     ` Viacheslav Dubeyko
2025-05-01 19:10       ` John Paul Adrian Glaubitz
2025-05-01 19:48         ` Viacheslav Dubeyko
2025-05-02 12:52           ` Theodore Ts'o
2025-05-05 22:31             ` Viacheslav Dubeyko
2025-05-02  0:07 ` Viacheslav Dubeyko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250429201517.101323-2-frank.li@vivo.com \
    --to=frank.li@vivo.com \
    --cc=glaubitz@physik.fu-berlin.de \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=slava@dubeyko.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox